Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript #76586

Merged
merged 4 commits into from Sep 3, 2020
Merged

[Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript #76586

merged 4 commits into from Sep 3, 2020

Conversation

FrankHassanabad
Copy link
Contributor

@FrankHassanabad FrankHassanabad commented Sep 2, 2020 •
edited

Summary

Removes RuleTypeSchema in favor of Type for TypeScript. Does break out one function called parseScheduleDates into its own file to remove a circular ref issue.

@FrankHassanabad FrankHassanabad requested review from a team as code owners September 2, 2020 23:04
@FrankHassanabad FrankHassanabad self-assigned this Sep 2, 2020
@FrankHassanabad FrankHassanabad added Feature:Detection Rules Anything related to Security Solution's Detection Rules release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.10.0 Team:SIEM labels Sep 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

FrankHassanabad
FrankHassanabad commented Sep 2, 2020
View reviewed changes
x-pack/plugins/security_solution/common/detection_engine/parse_schedule_dates.ts
: null;

return formattedDate ?? null;
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: I needed to break this function out of utils into this file because of a circular deps issue.

FrankHassanabad
FrankHassanabad commented Sep 2, 2020
View reviewed changes
x-pack/plugins/security_solution/common/detection_engine/utils.ts
: null;

return formattedDate ?? null;
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This is broken into its own file to remove circular deps issue.

yctercero
yctercero approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one thing is looks like maybe the parseScheduleDates import in x-pack/plugins/security_solution/server/lib/detection_engine/signals/signal_rule_alert_type.test.ts needs to be updated.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 9.8MB +1.1KB 9.8MB

page load bundle size

id value diff baseline
securitySolution 813.0KB -7.6KB 820.6KB

distributable file count

id value diff baseline
total 45382 +1 45381

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@FrankHassanabad FrankHassanabad merged commit 2f017b0 into elastic:master Sep 3, 2020
@FrankHassanabad FrankHassanabad deleted the make-type-common branch September 3, 2020 03:48
@FrankHassanabad FrankHassanabad mentioned this pull request Sep 3, 2020
Merged
FrankHassanabad added a commit to FrankHassanabad/kibana that referenced this pull request Sep 3, 2020
@FrankHassanabad
[Security Solution][Detection Engine] Remove RuleTypeSchema in favor …
7a11e2f 
…of Type for TypeScript (elastic#76586)

## Summary

Removes RuleTypeSchema in favor of Type for TypeScript. Does break out one function called `parseScheduleDates` into its own file to remove a circular ref issue.
FrankHassanabad added a commit that referenced this pull request Sep 3, 2020
@FrankHassanabad
[Security Solution][Detection Engine] Remove RuleTypeSchema in favor …
e62f687 
…of Type for TypeScript (#76586) (#76591)

## Summary

Removes RuleTypeSchema in favor of Type for TypeScript. Does break out one function called `parseScheduleDates` into its own file to remove a circular ref issue.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 3, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-pipeli…
81bad4f 
…nes/processors-forms-k-s

* 'master' of github.com:elastic/kibana: (216 commits)
  [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558)
  [Security Solution] add an excess validation instead of the exact match (elastic#76472)
  Introduce TS incremental builds & move src/test_utils to TS project  (elastic#76082)
  fix bad merge (elastic#76629)
  [Newsfeed] Ensure the version format when calling the API (elastic#76381)
  remove server_extensions mixin (elastic#76606)
  Remove legacy applications and legacy mode (elastic#75987)
  [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749)
  Replace FetchOptions with ISearchOptions (elastic#76538)
  Move streams utils to the core  (elastic#76397)
  [Ingest Manager] Wording & linking improvements (elastic#76284)
  remove legacy kibana plugin (elastic#76064)
  [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379)
  Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482)
  [APM] Service maps layout enhancements (elastic#76481)
  [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586)
  [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544)
  Index Pattern class - remove toJSON and toString (elastic#76246)
  skip failing suite (elastic#76581)
  Split up and clarify Enterprise Search codeowners (elastic#76580)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processor_settings_fields.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/foreach.tsx
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 3, 2020
@jloleysens
Merge branch 'ingest-pipelines/processors-forms-k-s' of github.com:jl…
480523f 
…oleysens/kibana into ingest-pipelines/processors-forms-k-s

* 'ingest-pipelines/processors-forms-k-s' of github.com:jloleysens/kibana: (216 commits)
  [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558)
  [Security Solution] add an excess validation instead of the exact match (elastic#76472)
  Introduce TS incremental builds & move src/test_utils to TS project  (elastic#76082)
  fix bad merge (elastic#76629)
  [Newsfeed] Ensure the version format when calling the API (elastic#76381)
  remove server_extensions mixin (elastic#76606)
  Remove legacy applications and legacy mode (elastic#75987)
  [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749)
  Replace FetchOptions with ISearchOptions (elastic#76538)
  Move streams utils to the core  (elastic#76397)
  [Ingest Manager] Wording & linking improvements (elastic#76284)
  remove legacy kibana plugin (elastic#76064)
  [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379)
  Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482)
  [APM] Service maps layout enhancements (elastic#76481)
  [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586)
  [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544)
  Index Pattern class - remove toJSON and toString (elastic#76246)
  skip failing suite (elastic#76581)
  Split up and clarify Enterprise Search codeowners (elastic#76580)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero approved these changes

Assignees

@FrankHassanabad FrankHassanabad

Labels
Feature:Detection Rules Anything related to Security Solution's Detection Rules release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@FrankHassanabad @elasticmachine @kibanamachine @yctercero @MindyRS