remove legacy kibana plugin #76064

pgayvallet · 2020-08-27T06:29:32Z

Summary

Part of #71927

Totally remove the legacy kibana plugin

elasticmachine · 2020-08-27T14:24:23Z

Pinging @elastic/kibana-platform (Team:Platform)

pgayvallet · 2020-08-27T14:26:05Z

src/legacy/server/config/schema.js

+    // temporarily moved here from the (now deleted) kibana legacy plugin
+    kibana: Joi.object({
+      enabled: Joi.boolean().default(true),
+      index: Joi.string().default('.kibana'),
+      autocompleteTerminateAfter: Joi.number().integer().min(1).default(100000),
+      // TODO Also allow units here like in elasticsearch config once this is moved to the new platform
+      autocompleteTimeout: Joi.number().integer().min(1).default(1000),
+    }).default(),
+


Some legacy code are still accessing these config properties from legacy. I moved them into the server's schema for now. This will have to be handled properly when we remove the legacy server totally.

We can remove quite a few validations here, not in the current PR, for sure

…gacy-kibana-plugin

mshustov · 2020-08-31T14:41:22Z

src/legacy/server/config/schema.js

+    // temporarily moved here from the (now deleted) kibana legacy plugin
+    kibana: Joi.object({
+      enabled: Joi.boolean().default(true),
+      index: Joi.string().default('.kibana'),
+      autocompleteTerminateAfter: Joi.number().integer().min(1).default(100000),
+      // TODO Also allow units here like in elasticsearch config once this is moved to the new platform
+      autocompleteTimeout: Joi.number().integer().min(1).default(1000),
+    }).default(),
+


We can remove quite a few validations here, not in the current PR, for sure

mshustov · 2020-08-31T14:46:23Z

src/legacy/server/config/schema.js

+      enabled: Joi.boolean().default(true),
+      index: Joi.string().default('.kibana'),
+      autocompleteTerminateAfter: Joi.number().integer().min(1).default(100000),
+      // TODO Also allow units here like in elasticsearch config once this is moved to the new platform


which team will be owning them? Both input_control_vis and data consume them

Yea, cleaning up the legacy server's config may require some discussions. Fortunately this is not required to shut down the legacy plugin system

mshustov · 2020-08-31T14:49:41Z

src/legacy/core_plugins/kibana/public/index.scss

-@import '@elastic/eui/src/themes/charts/theme';
-
-// Public UI styles
-@import 'src/legacy/ui/public/index';


Hm...cannot find this file. Does it exist?

Hum, actually it does. src/legacy/ui/public/_index.scss. I thought these css files were no longer imported, but seeing #76085 (comment), I might have been wrong

After talking with Spencer and Tyler, this file is no longer used, so we should be good to remove it

src/legacy/core_plugins/kibana/public/index.scss

…gacy-kibana-plugin

cchaos

SASS changes LGTM

…gacy-kibana-plugin

kibanamachine · 2020-09-03T07:54:00Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a784054

Build metrics

oss distributable file count

id	value	diff	baseline
total	27297	-3	27300

distributable file count

id	value	diff	baseline
total	45456	-3	45459

History

💚 Build #71527 succeeded 8014d60
💚 Build #71166 succeeded c9a8a89
💚 Build #70825 succeeded 9a02fc9
💔 Build #70778 failed 1742a5f
💔 Build #70771 failed 898369f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* remove legacy kibana plugin * as ES as a dependency to security instead of kibana * remove 'kibana' plugin presence check in so mixin * moved the `kibana` config section to the server

…nes/processors-forms-k-s * 'master' of github.com:elastic/kibana: (216 commits) [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558) [Security Solution] add an excess validation instead of the exact match (elastic#76472) Introduce TS incremental builds & move src/test_utils to TS project (elastic#76082) fix bad merge (elastic#76629) [Newsfeed] Ensure the version format when calling the API (elastic#76381) remove server_extensions mixin (elastic#76606) Remove legacy applications and legacy mode (elastic#75987) [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749) Replace FetchOptions with ISearchOptions (elastic#76538) Move streams utils to the core (elastic#76397) [Ingest Manager] Wording & linking improvements (elastic#76284) remove legacy kibana plugin (elastic#76064) [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379) Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482) [APM] Service maps layout enhancements (elastic#76481) [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586) [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544) Index Pattern class - remove toJSON and toString (elastic#76246) skip failing suite (elastic#76581) Split up and clarify Enterprise Search codeowners (elastic#76580) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processor_settings_fields.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/foreach.tsx

…oleysens/kibana into ingest-pipelines/processors-forms-k-s * 'ingest-pipelines/processors-forms-k-s' of github.com:jloleysens/kibana: (216 commits) [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558) [Security Solution] add an excess validation instead of the exact match (elastic#76472) Introduce TS incremental builds & move src/test_utils to TS project (elastic#76082) fix bad merge (elastic#76629) [Newsfeed] Ensure the version format when calling the API (elastic#76381) remove server_extensions mixin (elastic#76606) Remove legacy applications and legacy mode (elastic#75987) [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749) Replace FetchOptions with ISearchOptions (elastic#76538) Move streams utils to the core (elastic#76397) [Ingest Manager] Wording & linking improvements (elastic#76284) remove legacy kibana plugin (elastic#76064) [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379) Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482) [APM] Service maps layout enhancements (elastic#76481) [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586) [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544) Index Pattern class - remove toJSON and toString (elastic#76246) skip failing suite (elastic#76581) Split up and clarify Enterprise Search codeowners (elastic#76580) ...

pgayvallet added 4 commits August 27, 2020 08:28

remove legacy kibana plugin

898369f

as ES as a dependency to security instead of kibana

bb61e29

remove 'kibana' plugin presence check in so mixin

1742a5f

moved the kibana config section to the server

9a02fc9

pgayvallet added Feature:Legacy Removal Issues related to removing legacy Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0 labels Aug 27, 2020

pgayvallet marked this pull request as ready for review August 27, 2020 14:24

pgayvallet requested review from a team as code owners August 27, 2020 14:24

pgayvallet requested a review from a team August 27, 2020 14:24

pgayvallet commented Aug 27, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into kbn-xxx-remove-le…

c9a8a89

…gacy-kibana-plugin

chrisronline approved these changes Aug 31, 2020

View reviewed changes

mshustov approved these changes Aug 31, 2020

View reviewed changes

cchaos reviewed Aug 31, 2020

View reviewed changes

src/legacy/core_plugins/kibana/public/index.scss Show resolved Hide resolved

legrego approved these changes Aug 31, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into kbn-xxx-remove-le…

8014d60

…gacy-kibana-plugin

cchaos approved these changes Sep 2, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into kbn-xxx-remove-le…

a784054

…gacy-kibana-plugin

pgayvallet merged commit 593298e into elastic:master Sep 3, 2020

pgayvallet mentioned this pull request Sep 3, 2020

[7.x] remove legacy kibana plugin (#76064) #76605

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove legacy kibana plugin #76064

remove legacy kibana plugin #76064

pgayvallet commented Aug 27, 2020

elasticmachine commented Aug 27, 2020

pgayvallet Aug 27, 2020

mshustov Aug 31, 2020

mshustov Aug 31, 2020

mshustov Aug 31, 2020 •

edited

Loading

pgayvallet Sep 1, 2020

mshustov Aug 31, 2020

pgayvallet Aug 31, 2020

pgayvallet Aug 31, 2020

cchaos left a comment

kibanamachine commented Sep 3, 2020

remove legacy kibana plugin #76064

remove legacy kibana plugin #76064

Conversation

pgayvallet commented Aug 27, 2020

Summary

elasticmachine commented Aug 27, 2020

pgayvallet Aug 27, 2020

Choose a reason for hiding this comment

mshustov Aug 31, 2020

Choose a reason for hiding this comment

mshustov Aug 31, 2020

Choose a reason for hiding this comment

mshustov Aug 31, 2020 • edited Loading

Choose a reason for hiding this comment

pgayvallet Sep 1, 2020

Choose a reason for hiding this comment

mshustov Aug 31, 2020

Choose a reason for hiding this comment

pgayvallet Aug 31, 2020

Choose a reason for hiding this comment

pgayvallet Aug 31, 2020

Choose a reason for hiding this comment

cchaos left a comment

Choose a reason for hiding this comment

kibanamachine commented Sep 3, 2020

💚 Build Succeeded

Build metrics

oss distributable file count

distributable file count

History

mshustov Aug 31, 2020 •

edited

Loading