[Newsfeed] Ensure the version format when calling the API #76381

afharo · 2020-09-01T14:21:59Z

Summary

This PR ensures the kibanaVersion has the format X.Y.Z when sending requests to https://feeds.elastic.co/kibana/v{kibanaVersion}.json.

This way we avoid any -SNAPSHOT or other additional labels we may add to the versioning.

Resolves #76149

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

afharo · 2020-09-01T15:32:38Z

@elasticmachine merge upstream

kibanamachine · 2020-09-01T20:18:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 836478e

Build metrics

page load bundle size

id	value	diff	baseline
newsfeed	21.9KB	+80.0B	21.8KB

History

💔 Build #71598 failed 405e65a
💔 Build #71568 failed 181665d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-09-02T09:55:15Z

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

TinaHeiligers

It would be great if we didn't have to use a regex but it's not a big concern.
Either way, LGTM

TinaHeiligers · 2020-09-02T22:59:50Z

src/plugins/newsfeed/public/lib/api.ts

-  ) {}
+  ) {
+    // The API only accepts versions in the format `X.Y.Z`, so we need to drop the `-SNAPSHOT` or any other label after it
+    this.kibanaVersion = kibanaVersion.replace(/^(\d+\.\d+\.\d+).*/, '$1');


It would be cool if we could do something like this:

this.kibanaVersion = `${semver.coerce(kibanaVersion).major}.${semver.coerce(kibanaVersion).minor}.${semver.coerce(kibanaVersion).patch}`

but I'm not sure if it's permissible in public folders.

I thought about using semver for this, but I didn't want to increase the bundle size by adding an external library.

) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…) (#76624) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…) (#76623) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…nes/processors-forms-k-s * 'master' of github.com:elastic/kibana: (216 commits) [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558) [Security Solution] add an excess validation instead of the exact match (elastic#76472) Introduce TS incremental builds & move src/test_utils to TS project (elastic#76082) fix bad merge (elastic#76629) [Newsfeed] Ensure the version format when calling the API (elastic#76381) remove server_extensions mixin (elastic#76606) Remove legacy applications and legacy mode (elastic#75987) [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749) Replace FetchOptions with ISearchOptions (elastic#76538) Move streams utils to the core (elastic#76397) [Ingest Manager] Wording & linking improvements (elastic#76284) remove legacy kibana plugin (elastic#76064) [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379) Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482) [APM] Service maps layout enhancements (elastic#76481) [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586) [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544) Index Pattern class - remove toJSON and toString (elastic#76246) skip failing suite (elastic#76581) Split up and clarify Enterprise Search codeowners (elastic#76580) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processor_settings_fields.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/foreach.tsx

…oleysens/kibana into ingest-pipelines/processors-forms-k-s * 'ingest-pipelines/processors-forms-k-s' of github.com:jloleysens/kibana: (216 commits) [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558) [Security Solution] add an excess validation instead of the exact match (elastic#76472) Introduce TS incremental builds & move src/test_utils to TS project (elastic#76082) fix bad merge (elastic#76629) [Newsfeed] Ensure the version format when calling the API (elastic#76381) remove server_extensions mixin (elastic#76606) Remove legacy applications and legacy mode (elastic#75987) [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749) Replace FetchOptions with ISearchOptions (elastic#76538) Move streams utils to the core (elastic#76397) [Ingest Manager] Wording & linking improvements (elastic#76284) remove legacy kibana plugin (elastic#76064) [Form lib] Fix regression on field not being validated after reset to its default value. (elastic#76379) Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (elastic#76482) [APM] Service maps layout enhancements (elastic#76481) [Security Solution][Detection Engine] Remove RuleTypeSchema in favor of Type for TypeScript (elastic#76586) [Security Solution][Exceptions] - Updates enum schema and tests (elastic#76544) Index Pattern class - remove toJSON and toString (elastic#76246) skip failing suite (elastic#76581) Split up and clarify Enterprise Search codeowners (elastic#76580) ...

* master: (340 commits) [data.search.SearchSource] Remove legacy ES client APIs. (elastic#75943) [release notes] automatically retry on Github API 5xx errors (elastic#76447) [es_ui_shared] Fix eslint exhaustive deps rule (elastic#76392) [i18n] Integrate 7.9.1 Translations (elastic#76391) [APM] Update aggregations to support script sources (elastic#76429) [Security Solution] Refactor Network Top Countries to use Search Strategy (elastic#76244) Document security settings available on ESS (elastic#76513) [Ingest Manager] Add input revision to the config send to the agent (elastic#76327) [DOCS] Identifies cloud settings for Monitoring (elastic#76579) [DOCS] Identifies Cloud settings in Dev Tools (elastic#76583) [Ingest Manager] Better default value for fleet long polling timeout (elastic#76393) [data.indexPatterns] Fix broken rollup index pattern creation (elastic#76593) [Ingest Manager] Split Registry errors into Connection & Response (elastic#76558) [Security Solution] add an excess validation instead of the exact match (elastic#76472) Introduce TS incremental builds & move src/test_utils to TS project (elastic#76082) fix bad merge (elastic#76629) [Newsfeed] Ensure the version format when calling the API (elastic#76381) remove server_extensions mixin (elastic#76606) Remove legacy applications and legacy mode (elastic#75987) [Discover] Fix sidebar element focus behavior when adding / removing columns (elastic#75749) ...

elasticmachine · 2021-10-01T21:38:33Z

Pinging @elastic/kibana-core (Team:Core)

[Newsfeed] Ensure the version format when calling the API

181665d

afharo added release_note:skip Skip the PR/issue when compiling release notes Team:KibanaTelemetry Feature:Newsfeed Feature of the Newsfeed labels Sep 1, 2020

elasticmachine and others added 2 commits September 1, 2020 09:32

Merge branch 'master' into newsfeed/api-version-format

405e65a

Remove -SNAPSHOT from the test plugin for the builds to go through

836478e

afharo marked this pull request as ready for review September 2, 2020 09:55

afharo requested a review from a team as a code owner September 2, 2020 09:55

afharo added v7.10.0 v7.9.2 v8.0.0 labels Sep 2, 2020

afharo mentioned this pull request Sep 2, 2020

[test-failed]: Chrome UI Functional Tests1.test/functional/apps/home/_newsfeed·ts - homepage app Newsfeed has red icon which is a sign of not checked news #76149

Closed

TinaHeiligers approved these changes Sep 2, 2020

View reviewed changes

afharo merged commit e32c282 into elastic:master Sep 3, 2020

afharo deleted the newsfeed/api-version-format branch September 3, 2020 11:06

This was referenced Sep 3, 2020

[7.x] [Newsfeed] Ensure the version format when calling the API (#76381) #76623

Merged

[7.9] [Newsfeed] Ensure the version format when calling the API (#76381) #76624

Merged

afharo added a commit to afharo/kibana that referenced this pull request Sep 3, 2020

[Newsfeed] Ensure the version format when calling the API (elastic#76381

c902b07

) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021

lukeelmers added Feature:Telemetry and removed Team:KibanaTelemetry labels Oct 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Newsfeed] Ensure the version format when calling the API #76381

[Newsfeed] Ensure the version format when calling the API #76381

afharo commented Sep 1, 2020

afharo commented Sep 1, 2020

kibanamachine commented Sep 1, 2020

elasticmachine commented Sep 2, 2020

TinaHeiligers left a comment

TinaHeiligers Sep 2, 2020

afharo Sep 3, 2020

elasticmachine commented Oct 1, 2021

[Newsfeed] Ensure the version format when calling the API #76381

[Newsfeed] Ensure the version format when calling the API #76381

Conversation

afharo commented Sep 1, 2020

Summary

Checklist

For maintainers

afharo commented Sep 1, 2020

kibanamachine commented Sep 1, 2020

💚 Build Succeeded

Build metrics

page load bundle size

History

elasticmachine commented Sep 2, 2020

TinaHeiligers left a comment

Choose a reason for hiding this comment

TinaHeiligers Sep 2, 2020

Choose a reason for hiding this comment

afharo Sep 3, 2020

Choose a reason for hiding this comment

elasticmachine commented Oct 1, 2021