[Mappings editor] Add support for point field type #77543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
added
release_note:enhancement
Feature:Index Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
yuliacech
reviewed
Sep 18, 2020
...nts/mappings_editor/components/document_fields/field_parameters/ignore_z_value_parameter.tsx
Outdated
Show resolved
Hide resolved
yuliacech
reviewed
Sep 18, 2020
There was a problem hiding this comment.
Hi @alisonelizabeth, great work on this field type!
Tested locally and the editor worked for the point type.
But I noticed that metadata parameter is throwing an error for all field types, if the switch is enabled, but no json was provided in the input field. The form will not save and the console shows following:
parameters_definition.tsx:428 Uncaught (in promise) SyntaxError: Unexpected end of JSON input
at JSON.parse (<anonymous>)
at serializer (parameters_definition.tsx:428)
at Object.__serializeValue (use_field.ts:71)
at use_form.ts:127
at utils.ts:42
at Array.reduce (<anonymous>)
at mapFormFields (utils.ts:41)
at use_form.ts:127
at Object.submit (use_form.ts:282)
at async submitForm (edit_field.tsx:42)
…ngs_editor/point_field
|
Thanks for the review @yuliacech!
Great catch! This was a regression that was introduced when doing some refactoring via #76671. I fixed it as part of this PR. Would you mind taking another look? |
|
Hi @alisonelizabeth, thank you for addressing this! |
yuliacech
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Hey @alisonelizabeth,
tested locally and all works, great work on these fixes!
|
@alisonelizabeth Do you think it'd be possible to add a test (in either this PR or a separate one) that would have caught the metadata regression? |
|
@cjcenizal 👍 Good call. I've added a few tests for the |
cjcenizal
approved these changes
Sep 21, 2020
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
miscellaneous assets size
page load bundle size
History
To update your PR or re-run it, just comment with: |
alisonelizabeth
added a commit
to alisonelizabeth/kibana
that referenced
this pull request
Sep 22, 2020
alisonelizabeth
added a commit
that referenced
this pull request
Sep 22, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 22, 2020
* master: (45 commits) [CSM] Use stacked chart for page views (elastic#78042) [Enterprise Search] Fix various plugin states when app has error connecting to Enterprise Search (elastic#78091) Remove service map beta badge (elastic#78039) [Enterprise Search] Rename "telemetry" to "stats" (elastic#78124) [Alerting] optimize calculation of unmuted alert instances (elastic#78021) call .destroy on ace when react component unmounts (elastic#78132) [Ingest Manager] Fix agent action acknowledgement (elastic#78089) [Upgrade Assistant] Rename "telemetry" to "stats" (elastic#78127) [Security Solution] Refactor Hosts Kpi to use Search Strategy (elastic#77606) Bump backport to 5.6.0 (elastic#78097) [Actions] adds a Test Connector tab in the Connectors list (elastic#77365) [Uptime] Improve ping chart axis (elastic#77992) [TSVB] Fields dropdowns are not populated if one of the indices is missing (elastic#77363) [UiActions] Remove duplicate apply filter action (elastic#77485) [APM] Use transaction metrics for transaction error rate (elastic#78009) [ES-ARCHIVER] Fix bug when query flag is empty (elastic#77983) Edit UI text strings in Integrations and Fleet tabs (elastic#75837) [baseline capture] switch to large workers (elastic#78109) [SECURITY_SOLUTION] list UI is backwards compatible (elastic#77956) [Mappings editor] Add support for point field type (elastic#77543) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76809
Release note
The mappings editor in the Index Templates UI now supports configuring the point field type.