Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Fix various plugin states when app has error connecting to Enterprise Search #78091

Merged
merged 2 commits into from
Sep 22, 2020
Merged

[Enterprise Search] Fix various plugin states when app has error connecting to Enterprise Search #78091

merged 2 commits into from
Sep 22, 2020

Conversation

cee-chen
Copy link
Member

Summary

When Enterprise Search is stopped/has errors connecting:

Before

  • App Search & Workplace Search were crashing w/ blank pages, due to AppLogic still being initialized w/ no fallbacks to empty objs
  • The Enterprise Search Overview plugin was showing a blank page with no meaningful messaging

After

  • AS & WS should now show the Error Connecting prompts once more without crashes from AppLogic
  • Enterprise Search Overview now shows shared error connecting prompt, like AS & WS

NOTE: The Setup Guide for Enterprise Search is NYI/will be discussed in sync tomorrow and implemented by @scottybollinger

Checklist

@cee-chen cee-chen added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 21, 2020
@cee-chen cee-chen marked this pull request as ready for review September 21, 2020 21:45
@cee-chen cee-chen requested review from a team as code owners September 21, 2020 21:45
scottybollinger
scottybollinger approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and have tested locally. Thanks Constance! 💯

@cee-chen
Copy link
Member Author

Thanks Scotty! @JasonStoltz or @byronhulcher - any chance I could get a quick ✅ from you on the App Search changes?

Separately, @scottybollinger I'm starting to wonder if splitting up our CODEOWNERS by team is starting to be more of a hassle than it's worth given our small team sizes. What do you think - maybe we just should just use @elastic/enterprise-search-frontend and call it a day? (Or re-evaluate in a month's time and see how we feel?)

@scottybollinger
Copy link
Contributor

Thanks Scotty! @JasonStoltz or @byronhulcher - any chance I could get a quick ✅ from you on the App Search changes?

Separately, @scottybollinger I'm starting to wonder if splitting up our CODEOWNERS by team is starting to be more of a hassle than it's worth given our small team sizes. What do you think - maybe we just should just use @elastic/enterprise-search-frontend and call it a day? (Or re-evaluate in a month's time and see how we feel?)

I'm totes fine with changing it, but I can see the benefit once we start having multiple engineers working on each product. You and Jason for now and Vadim and me, once he starts contributing.

How about we re-evaluate in a month?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen
Copy link
Member Author

Thanks a ton Byron & Scotty! 🙇

@cee-chen cee-chen merged commit 99f6524 into elastic:master Sep 22, 2020
@cee-chen cee-chen deleted the error-connecting-fixes branch September 22, 2020 15:38
@cee-chen cee-chen mentioned this pull request Sep 22, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 22, 2020
@gmmorris
Merge branch 'master' into actions/pagerduty-dedup
56e81d2 
* master: (45 commits)
  [CSM] Use stacked chart for page views (elastic#78042)
  [Enterprise Search] Fix various plugin states when app has error connecting to Enterprise Search (elastic#78091)
  Remove service map beta badge (elastic#78039)
  [Enterprise Search] Rename "telemetry" to "stats" (elastic#78124)
  [Alerting] optimize calculation of unmuted alert instances (elastic#78021)
  call .destroy on ace when react component unmounts (elastic#78132)
  [Ingest Manager] Fix agent action acknowledgement (elastic#78089)
  [Upgrade Assistant] Rename "telemetry" to "stats" (elastic#78127)
  [Security Solution] Refactor Hosts Kpi to use Search Strategy (elastic#77606)
  Bump backport to 5.6.0 (elastic#78097)
  [Actions] adds a Test Connector tab in the Connectors list (elastic#77365)
  [Uptime] Improve ping chart axis (elastic#77992)
  [TSVB] Fields dropdowns are not populated if one of the indices is missing (elastic#77363)
  [UiActions] Remove duplicate apply filter action  (elastic#77485)
  [APM] Use transaction metrics for transaction error rate (elastic#78009)
  [ES-ARCHIVER] Fix bug when query flag is empty (elastic#77983)
  Edit UI text strings in Integrations and Fleet tabs (elastic#75837)
  [baseline capture] switch to large workers (elastic#78109)
  [SECURITY_SOLUTION] list UI is backwards compatible (elastic#77956)
  [Mappings editor] Add support for point field type (elastic#77543)
  ...
cee-chen pushed a commit that referenced this pull request Sep 22, 2020
[Enterprise Search] Fix various plugin states when app has error conn…
245944f 
…ecting to Enterprise Search (#78091) (#78164)

* Display error connecting prompt on Overview page instead of blank page

* Fix App Search and Workplace Search to not crash during error connecting
- due to obj type errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottybollinger scottybollinger scottybollinger approved these changes

@byronhulcher byronhulcher byronhulcher approved these changes

Assignees
No one assigned
Labels
Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cee-chen @scottybollinger @kibanamachine @byronhulcher