Fix suggestions dropdown for query input

[sulemanof]

Summary

Fixes #80831

Initial issue: When changing an index pattern in TSVB under panel options from the default one, the KQL autocompletion under "Panel filter" will still show the fields of the default index pattern until you switched away from the Panel Options tab and back to it (unmount - mount the filter component).

It seems the problem was in order of calling updateSuggestions method. Here are logs of async fetchIndexPatterns calls:

Steps:

• typing the kibana_sample_data_logs index pattern;
• the first call used kibana_sample_data_log and freezed until fetchIndexPatterns completed;
• right after the second call with kibana_sample_data_logs - then the resolved fetchIndexPatterns immediately updates the suggestions - and then the first call takes precedence and overrides the suggestions value

The fix bring in the AbortController to abort the previous fetchIndexPatterns.
Also, the debounce was added to reduce the amount of calls.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[Dosant]

I didn't test but, if I understood this correctly, this doesn't seem to be working as intended 🤔
Currently every time we are checking the LATEST abort controller, but we should instead check to the
abort controller which was created when we fired a corresponding fetch:

I think it should look something like this instead:

if (this.lastAbortController) this.lastAbortController.abort(); // make sure any older requests are canceled.
this.lastAbortController = new AbortController();
const currentAbortController = this.lastAbortController;
await fetch();
if (!currentAbortController.signal.aborted) {
 // 
 this.setState()
 this.updateSuggestions
}

[sulemanof]

Thanks @Dosant , updated

[sulemanof]

@elasticmachine merge upstream

[stratoula]

Code is LGTM, I can't replicate the bug always, but I managed to replicate it on master. I can't replicate it with the new changes so it seems fine to me 🙂

[sulemanof]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 17f0407

Metrics [docs]

async chunks size

id	before	after	diff
data	286.8KB	287.2KB	+394.0B

History

• 💚 Build #83283 succeeded 51f5bd6
• 💛 Build #83002 was flaky 9ad9334
• 💔 Build #82817 failed 0e8cd20
• 💚 Build #82480 succeeded 29cc3ca
• 💚 Build #82446 succeeded 9fb9d94

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[Dosant]

Code LGTM, didn't test