Attempt to fix incremental build error

[mshustov]

Summary

From time to time yarn kbn bootstrap fails with a cryptic error:

src/plugins/usage_collection/server/collector/collector_set.ts:109:41 - error TS2345: Argument of type 'Collector<TFetchReturn, TFormatForBulkUpload, ExtraOptions>' is not assignable to parameter of type 'AnyCollector'.
              Types of property 'fetch' are incompatible.
                Type 'CollectorFetchMethod<any, TFetchReturn, ExtraOptions>' is not assignable to type 'CollectorFetchMethod<any, any, {}>'.
                  Type '{}' is not assignable to type 'ExtraOptions'.
                    '{}' is assignable to the constraint of type 'ExtraOptions', but 'ExtraOptions' could be instantiated with a different subtype of constraint 'object'.
            109     this.collectors.set(collector.type, collector);
                                                        ~~~~~~~~~

At the same time, neither VSCode nor Webstorm shows the errors. It makes me think there is a problem with type inference for the Collector class. I tried to isolate an error case, but the complexity of type generics in https://github.com/elastic/kibana/blob/030343d9320bf22721b18ffdb45a063b5f391298/src/plugins/usage_collection/server/collector/collector.ts is not trivial. So I assumed that problem might be with the fetch type itself not satisfying the constraints.

[afharo]

Reading the error, it looks to me like TS complains about this line:
https://github.com/restrry/kibana/blob/attepmpt-to-fix-floating-type-error/src/plugins/usage_collection/server/collector/collector_set.ts#L109

In that one, we are setting the Collector<TFetchReturn, TFormatForBulkUpload, ExtraOptions> to a Map<string, AnyCollector>.

AnyCollector is Collector<any, any> (with TS turns into Collector<any, any, {}>).

So, essentially, we are trying to assign Collector<TFetchReturn, TFormatForBulkUpload, ExtraOptions> to Collector<any, any, {}>.

Since the error claims Type '{}' is not assignable to type 'ExtraOptions', I think the actual fix is to define:

type AnyCollector = Collector<any, any, any>;
type AnyUsageCollector = UsageCollector<any, any, any>;

The currently proposed changes feel to me like they add more constraints to the types (instead of accepting any, they only accept boolean | undefined).
What do you think @restrry?

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 0e848a5

Metrics [docs]

✅ unchanged

History

• 💚 Build #89800 succeeded 030343d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[afharo]

LGTM!