Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timelion not working with single quotes #84196

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Fix timelion not working with single quotes #84196

merged 3 commits into from
Nov 24, 2020

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Nov 24, 2020 •
edited
Loading

Summary

Fixes #83297

Skip escaping single quotes since it is handled appropriately inside interpreter

Checklist

Delete any items that are not applicable to this PR.

For maintainers

stratoula
stratoula approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it locally, now it works with both single and double quotes. Thanx for the test added Daniiil 👏

@sulemanof sulemanof marked this pull request as ready for review November 24, 2020 12:44
@sulemanof sulemanof requested a review from a team November 24, 2020 12:44
ppisljar
ppisljar approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@sulemanof sulemanof merged commit b312c91 into elastic:master Nov 24, 2020
@sulemanof sulemanof deleted the fix/timelion_escape_string branch November 24, 2020 15:16
@sulemanof sulemanof mentioned this pull request Nov 24, 2020
Merged
sulemanof pushed a commit to sulemanof/kibana that referenced this pull request Nov 24, 2020
@sulemanof
Fix timelion vis escapes single quotes (elastic#84196)
d83e234 
* Remove string escaping

* Add unit test
sulemanof pushed a commit to sulemanof/kibana that referenced this pull request Nov 24, 2020
@sulemanof
Fix timelion vis escapes single quotes (elastic#84196)
a4fb489 
* Remove string escaping

* Add unit test
@sulemanof sulemanof mentioned this pull request Nov 24, 2020
Merged
@timroes timroes changed the title Fix timelion vis escapes single quotes Fix timelion not working with single quotes Nov 24, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeTimelion 34.8KB 34.8KB -29.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

rylnd added a commit to rylnd/kibana that referenced this pull request Nov 24, 2020
@rylnd
Merge branch 'master' into fix_rule_form_bugs
9e01ff6 
* master: (41 commits)
  [Maps] fix code-owners (elastic#84265)
  [@kbn/utils] Clean target before build (elastic#84253)
  [code coverage] collect for oss integration tests (elastic#83907)
  [APM] Use `asTransactionRate` consistently everywhere (elastic#84213)
  Attempt to fix incremental build error (elastic#84152)
  Unskip "Copy dashboards to space" (elastic#84115)
  Remove expressions.legacy from README (elastic#79681)
  Expression: Add render mode and use it for canvas interactivity (elastic#83559)
  [deb/rpm] Move systemd service to /usr/lib/systemd/system (elastic#83571)
  [Security Solution][Resolver] Allow a configurable entity_id field (elastic#81679)
  [ML] Space permision checks for job deletion (elastic#83871)
  [build] Provide ARM build of RE2 (elastic#84163)
  TSVB should use "histogram:maxBars" and "histogram:barTarget" settings for auto instead of a default 100 buckets (elastic#83628)
  [Workplace Search] Initial rendering of Org Sources (elastic#84164)
  update geckodriver to 0.28 (elastic#84085)
  Fix timelion vis escapes single quotes (elastic#84196)
  [Security Solution] Fix incorrect time for dns histogram (elastic#83532)
  [DX] Bump TS version to v4.1 (elastic#83397)
  [Security Solution] Add endpoint policy revision number (elastic#83982)
  [Fleet] Integration Policies List view (elastic#83634)
  ...
sulemanof pushed a commit that referenced this pull request Nov 25, 2020
Fix timelion vis escapes single quotes (#84196) (#84230)
938f7f9 
* Remove string escaping

* Add unit test
sulemanof pushed a commit that referenced this pull request Nov 25, 2020
Fix timelion vis escapes single quotes (#84196) (#84231)
b08df68 
* Remove string escaping

* Add unit test
@camprr
Copy link

camprr commented Nov 25, 2020

Any idea when this will be released? I am assuming because it's in 'master' now, it will be released with 7.10.1?

@sulemanof
Copy link
Contributor Author

Any idea when this will be released? I am assuming because it's in 'master' now, it will be released with 7.10.1?

Hey @camprr
This will be release in 7.10.1 & 7.11 as well

p.s.: you can always be aware of release versions in the Labels section of a PR:

image

@dcbeckett dcbeckett mentioned this pull request Nov 30, 2020
Closed
@ayushmathur86
Copy link

Hi,
When the release 7.11 be available as rpm ? We need this fix quite urgently on production - do I need to raise case with Elastic Support ?

@stratoula
Copy link
Contributor

Hey @ayushmathur86 we are planning to release 7.10.1 which will also contain this fix within the upcoming weeks 🙂

@ayushmathur86
Copy link

Thanks @stratoula , that will be awesome. Any tentative date for which I can raise an internal JIRA :-) ?

@timroes
Copy link
Contributor

timroes commented Dec 1, 2020

@ayushmathur86 The specific release date will depend on how testing goes and some other factors, so we unfortunately can't give you a specific date, but it's planned within the next 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
Feature:Timelion Timelion app and visualization regression release_note:fix v7.10.1 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timelion in 7.10.0 does not work with single quotations anymore
7 participants
@sulemanof @kibanamachine @camprr @ayushmathur86 @stratoula @timroes @ppisljar