-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: load_config pattern #1831
Comments
If we do this, this one is also related. |
Is there still interest in this? |
For me there is. Also I believe I recall another issue opened about globbling only *.conf files. |
@jordansissel WDYT? |
I would be ok with dropping directory support and only supporting globs or On Tuesday, March 8, 2016, Suyog Rao notifications@github.com wrote:
|
I think doing this would allow people to specify -f logstash/conf.d and it I'm not sure if it's even possible but wondering if there is a way to have
|
@cdenneen I confess that my resistance to "ignore backup files" or similar is because it's been a very long time since I've managed machines in a way that you describe, for example, If I try to think as a user might, having directory support ( So my proposal is:
The above, I hope, would solve your problem of Thoughts? |
I don't consider this optional. Some kind of support for globbing configuration files is necessary. I suppose that means Logstash's command line interface would be changed to not accept configuration files via the |
@magnusbaeck oops, I may have been confusing.
I completely agree. Summary of my proposal roughly:
My proposal is to remove directory support only. Glob support would stay, so users would still be able to do |
My optional suggestion was to ensure that our system packages default to using something like Sorry if I was being confusing; let me know if I'm making sense :) |
The problem with |
I tend to agree explicitly adding wildcards could get messy and the
|
@magnusbaeck I agree with your philosophy about unix tooling and that the shell can do the globbing in most cases. However, Logstash has for years supported this globbing via
And we support Windows. So what I"m saying is the |
I don't feel this change would be safe for users as folks who do not name their files with I'm still open to my proposal as stated, but right now, I am against having a directory imply |
In the rsync and Git cases they need to have their own globbing since the shell can't do it for them which at least for me is much easier to understand. The important part here is making sure that
Indeed not, which makes cross-platform programming a PITA. Well, it's one of those things that make Windows programming in general a PITA.
I see no reason to change that. |
Let's open a different issue to discuss this point. |
Any news about this change @jordansissel ? |
@rhoml I'm not sure what the exact proposal is anymore, hah. Can someone write up a summary of the behavior that is being proposed? I'm open to whatever :) |
@jordansissel I would like to pick this one up for 6.0. A few users have got hit by this and 6.0 is a good time to do this change. I can summarize my proposal here so we can discuss:
This way we can harden it OOTB, but allow for users who don't use WDYT? |
hmm, your proposal in #6979 actually makes more sense. I'll move forward with that. |
If deemed valuable to others:
Would it be possible for someone with ruby experience to update the globbing of configs to be *.conf (might be just as simple as changing line 288 of agent.rb). This would allow you to also keep backups of old configs or move configs out of the way if you want to piecemeal during testing which configs are live. (luckily the added bonus even with * is that private directories like .git aren't sourced so the entire logstash/conf.d can be under version control)
The text was updated successfully, but these errors were encountered: