Only glob *.conf by default in conf.d folder #7130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyograo
force-pushed
the
allow_conf_files
branch
from
997c046
to
827fa94
Compare
|
Change looks good. Any thoughts on an acceptance test for this? |
| def get_unmatched_files | ||
| # transform "/var/lib/*.conf" => /var/lib/* | ||
| t = File.split(@path) | ||
| all_files = Dir.glob(File.join(t.first, "*")).sort |
There was a problem hiding this comment.
This will not show hidden (dot files) in the list of unmatched. I don't anticipate this to be confusing to users, but wanted to point it out.
If a user has a file named '.foo.conf' it will not be matched, nor will '.foo.bar' be shown as being skipped.
|
@jordansissel I'd love to add acceptance tests, but they are all broken already. Tracking here: #7123 How about I create an issue and add an acceptance for this when #7123 is settled? |
|
+1 on creating an issue and adding later. |
jordansissel
approved these changes
May 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6979, Fixes #1831