-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Published logstash-core not working for 5.1.x #6374
Comments
I had the log4j classpath error, too. What was weird was that sometimes I could click "Restart Build" and it would work. |
Taking a look |
The generated specification looks OK see https://gist.github.com/ph/aa0930b3dd7581c4748371ef131c41d1 |
At install time we can see that jar dependencies picks up things and install them.
Note the version difference between the logstash-core-event and the logstash-core, we will need to pin the version, but its not the source of the described problem. When you try to run the test in a plugin repository it will fail with the following error:
My current theory is the require order changed or something is missing in the $LOAD_PATH and the
|
If we take a step back and look at a previous failling in a plugin travis job
We see in the trace something related to devutils, at line 15 we require the logging file, we do not require anything else from Logstash before that point. # from spec_helper
require "logstash/logging" At that time in the test the |
@colinsurprenant You are right, jar dependencies should have picked the dependencies, like log4j and we clearly see it in the bundle install log. Adding *.jar in the gemspec is still required to make sure the gem contains our custom |
@ph agree, but we only need to include our generated jar, not the dependencies which are installed by jar-dependencies |
fixed in the latest snapshot 5.1.2 of the gem. |
Hi @ph , Is there any workaround in 5.1.1? I tried to reference the gem snapshot in my gemspec but it requires 'logstash-core-event-java (= 5.1.2.snapshot1) java' which is not deployed in rubygems |
@cpiment Can you try again? we have released a new version of the core gems 5.1.1.1? |
It worked Thanks! |
Hi, |
@MichaelRuhwedel thanks for the heads up, https://rubygems.org/gems/logstash-core-queue-jruby/versions/5.1.2-java has been published |
Hi, I am using logstash-core-plugin-api 2.1.22 which depends on logstash-core 5.1.1.1 (https://rubygems.org/gems/logstash-core-plugin-api) and thus I have the same error when trying to run my tests. Do you know when logstash-core-plugin-api will be released on RubyGems with a dependency to a newer logstash-core ? |
@rnowif : To get rid of
Explicitly specifying this: -s.add_development_dependency "logstash-devutils",
+s.add_development_dependency "logstash-devutils", "~> 1.3", ">= 1.3.1" worked for me. |
Wow, thank you so much for this :-) |
I just published a snapshot version of logstash-core and their friends: logstash-core-event-java, logstash-core-queue-jruby, logstash-core-plugin-api. There are 2 issues:
log4j*
jars are not getting loaded.The text was updated successfully, but these errors were encountered: