Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.2.4 release broke plugin #9592

Closed
josephlewis42 opened this issue May 16, 2018 · 4 comments
Closed

6.2.4 release broke plugin #9592

josephlewis42 opened this issue May 16, 2018 · 4 comments
Labels
bug P2 Priority 2 Bug

Comments

@josephlewis42
Copy link

Hi,

It looks like this PR in the 6.2.4 Logstash release broke the logstash-input-google_pubsub plugin. More info about it is in this pubsub PR.

Reverting the version of google-java-format from 1.5 to 1.1 caused the guava version to drop from 22 (released in 2017) to 19 (released in 2015).

This issue is likely to come up with the four (soon to be five) other Google Logstash plugins to stop working as the Google Cloud API changes.

Is there any way to get the Guava version bumped back up to 20 or above? Or is there something we can do on our side to make sure our Guava JAR is used over the bundled one?

Thanks!
@josephlewis42 josephlewis42 mentioned this issue May 16, 2018
Closed
@andrewvc andrewvc added bug P2 Priority 2 Bug labels May 21, 2018
andrewvc added a commit to andrewvc/logstash that referenced this issue May 21, 2018
@andrewvc
Explicitly depend on guava 22
7fba20e 
We only depended on it transitively in the past, this makes it explicit.

This caused an issue in the google pubsub plugins, reported here: elastic#9592

In the future, this will be a non-concern when your java plugin API launch with classloader isolation.
@andrewvc andrewvc mentioned this issue May 21, 2018
Closed
@andrewvc
Copy link
Contributor

@josephlewis42 apologies. #9622 should fix this. The real fix is #9215 , which will include a parent last class loader policy that will let you bundle your own Guava.

elasticsearch-bot pushed a commit that referenced this issue May 21, 2018
@andrewvc
Explicitly depend on guava 22
b2fc4fc 
We only depended on it transitively in the past, this makes it explicit.

This caused an issue in the google pubsub plugins, reported here: #9592

In the future, this will be a non-concern when your java plugin API launch with classloader isolation.

Fixes #9622
elasticsearch-bot pushed a commit that referenced this issue May 21, 2018
@andrewvc
Explicitly depend on guava 22
3a578f5 
We only depended on it transitively in the past, this makes it explicit.

This caused an issue in the google pubsub plugins, reported here: #9592

In the future, this will be a non-concern when your java plugin API launch with classloader isolation.

Fixes #9622
@josephlewis42
Copy link
Author

@andrewvc thank you so much!

This was referenced May 25, 2018
Closed
Merged
@danhermann
Copy link
Contributor

@andrewvc, can this be closed if #9622 fixes it?

@danhermann
Copy link
Contributor

Fixed in #9622 and #9836.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug P2 Priority 2 Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewvc @josephlewis42 @danhermann