This brings back --filter-workers for the 2.x series. This will be go… #4672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if filter_workers | ||
| @logger.warn("--filter-workers is deprecated! Please use --pipeline-workers. This setting will be removed in the next major version!") | ||
| self.pipeline_workers=filter_workers |
|
Can you update the commit message to say |
| @@ -134,6 +138,12 @@ def execute | |||
| end | |||
| configure | |||
|
|
|||
|
|
|||
| if filter_workers | |||
| @logger.warn("--filter-workers is deprecated! Please use --pipeline-workers. This setting will be removed in the next major version!") | |||
There was a problem hiding this comment.
Add
Please use --pipeline-workers or -w. This setting..
andrewvc
force-pushed
the
fix_missing_pipeline_Workers_flag
branch
from
76a46d1
to
4eaa30a
Compare
…ne in the next major version Fixes elastic#4669
andrewvc
force-pushed
the
fix_missing_pipeline_Workers_flag
branch
from
4eaa30a
to
86dbfd6
Compare
|
@suyograo @jordansissel I believe I have addressed all concerns here with my last force push. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ne in the next major version