Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResultsPerPage component should have configurable options #60

Closed
JasonStoltz opened this issue Feb 5, 2019 · 3 comments
Closed

ResultsPerPage component should have configurable options #60

JasonStoltz opened this issue Feb 5, 2019 · 3 comments
Labels
effort: 1 good first issue Good for newcomers
Milestone
v0.8.0

Comments

@JasonStoltz
Copy link
Member

JasonStoltz commented Feb 5, 2019 •
edited
Loading

Currently, the options "20", "40", and "60" are hardcoded as options in the ResultsPerPage components: https://github.com/elastic/search-ui/blob/master/packages/react-search-ui/src/containers/ResultsPerPage.js#L38.

This should be configurable, as users may want options other than these defaults.
@JasonStoltz JasonStoltz added the good first issue Good for newcomers label Apr 22, 2019
@JasonStoltz JasonStoltz mentioned this issue Apr 22, 2019
Closed
@m-sureshraj
Copy link
Contributor

I would like to work on this issue. How can I assign this issue to myself?

@JasonStoltz
Copy link
Member Author

@m-sureshraj For now, I'd say just comment here (like you've done) and enter a PR.

@m-sureshraj m-sureshraj mentioned this issue Apr 28, 2019
Merged
@m-sureshraj
Copy link
Contributor

PR - #224

@JasonStoltz JasonStoltz added this to the v0.8.0 milestone May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: 1 good first issue Good for newcomers
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
2 participants
@JasonStoltz @m-sureshraj