Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat]: add mappings for performance metrics #26140

Merged

Conversation

vigneshshanmugam
Copy link
Member

@vigneshshanmugam vigneshshanmugam added enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.14.0 labels Jun 3, 2021
@vigneshshanmugam vigneshshanmugam requested a review from a team as a code owner June 3, 2021 20:42
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 3, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 3, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26140 updated

  • Start Time: 2021-06-07T18:14:59.125+0000

  • Duration: 75 min 19 sec

  • Commit: 2ae0911

Test stats 🧪

Test Results
Failed 0
Passed 3347
Skipped 82
Total 3429

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 3347
Skipped 82
Total 3429

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use some improvements on the docs side, but otherwise good

heartbeat/_meta/fields.common.yml Outdated Show resolved Hide resolved
heartbeat/_meta/fields.common.yml Show resolved Hide resolved
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigneshshanmugam
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2021

Command update: success

Branch has been successfully updated

@vigneshshanmugam vigneshshanmugam merged commit cb085d0 into elastic:master Jun 7, 2021
@vigneshshanmugam vigneshshanmugam deleted the update-browser-mapping branch June 7, 2021 20:10
@vigneshshanmugam
Copy link
Member Author

@Mergifyio backport 7.x

mergify bot pushed a commit that referenced this pull request Jun 11, 2021
* [Heartbeat]: add mappings for performance metrics

* build new mappings

* address review comments

* update fields

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit cb085d0)

# Conflicts:
#	heartbeat/_meta/fields.common.yml
#	heartbeat/docs/fields.asciidoc
#	heartbeat/include/fields.go
#	x-pack/heartbeat/include/fields.go
@mergify
Copy link
Contributor

mergify bot commented Jun 11, 2021

Command backport 7.x: success

Backports have been created

vigneshshanmugam added a commit that referenced this pull request Jun 24, 2021
…26252)

* [Heartbeat]: add mappings for performance metrics (#26140)

* [Heartbeat]: add mappings for performance metrics

* build new mappings

* address review comments

* update fields

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit cb085d0)

# Conflicts:
#	heartbeat/_meta/fields.common.yml
#	heartbeat/docs/fields.asciidoc
#	heartbeat/include/fields.go
#	x-pack/heartbeat/include/fields.go

* fix diff correctly

Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Heartbeat] Add mappings for synthetics browser metrics
3 participants