Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples must be excluded from the project scope #3

Closed
6 tasks done
elbraulio opened this issue Oct 23, 2018 · 5 comments
Closed
6 tasks done

examples must be excluded from the project scope #3

elbraulio opened this issue Oct 23, 2018 · 5 comments
Labels
bug Something isn't working

Comments

@elbraulio
Copy link
Owner

elbraulio commented Oct 23, 2018 •
edited
Loading

it is not suitable to have examples within the project because they have not have unit test and increments the project complexity. These tools must be provided by the project but without containing examples inside ignored test. This packages must be excluded from the main project and can be included on a examples branch:

  • launcher

  • GithubInfoTest

  • ignored test from FetchUsersPageListTest

  • FetchAnswersTest

  • IteratePagedContentTest

  • ParticipantsTest
@elbraulio elbraulio added the bug Something isn't working label Oct 23, 2018
@elbraulio elbraulio added this to the v1.0 milestone Oct 23, 2018
@elbraulio
Copy link
Owner Author

they will be included in other repo

@elbraulio
Copy link
Owner Author

meanwhile it will be created a new example branch to save those files. And they will be deleted from master branch

@elbraulio elbraulio mentioned this issue Dec 14, 2018
Open
@elbraulio
Copy link
Owner Author

example branch created

@elbraulio elbraulio removed this from the v0.1 milestone Dec 14, 2018
@elbraulio
Copy link
Owner Author

examples executable deleted 065df92

@elbraulio
Copy link
Owner Author

ignored test removed 8175132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elbraulio