Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some convertesr can't reuse #1

Closed
elda27 opened this issue Aug 3, 2020 · 2 comments
Closed

Some convertesr can't reuse #1

elda27 opened this issue Aug 3, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@elda27
Copy link
Owner

elda27 commented Aug 3, 2020

The implementation of some converters can't reuse.
The example shows the following.

input1 = np.array([
    'Tom',
    'Becky',
    'Tom',
    'Becky',
    'Ann',
])
converter = prepnet.OrdinalConverter()
result = converter.encode(input1)
print(result) # Display text should be "[0, 1, 0, 1, 2]"

input2 = np.array([
    'Tom',
    'Tom',
    'Ann',
])
result = converter.encode(inputs)
print(result) # Display text should be "[0, 0, 2]" but actual "[0, 0, 1]"
@elda27 elda27 added the bug Something isn't working label Aug 3, 2020
@elda27
Copy link
Owner Author

elda27 commented Aug 3, 2020

List of the subject classes.

  • OrdinalConverter
  • OnehotConverter
  • Standardize

Other classes will be added when I realize it.

@elda27
Copy link
Owner Author

elda27 commented Aug 15, 2020

almost fixed

@elda27 elda27 closed this as completed Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant