Possible issue in the new ShapeManager code.

[davidmartos96]

cc @msfstef

While porting the new ShapeManager refactor to Dart we found an issue that we are unsure if it could cause unexpected problems.

electric/clients/typescript/src/satellite/shapes/shapeManager.ts

Line 331 in 276149d

this.promises[fullKey].resolve()

The following line is accessing the promise resolver unconditionally, but it can be undefined. It currently throws, but the exception is not bubbled up because of the Promise.allSettled in the AsyncEventEmitter.

In fact, one of the tests reaches this situation, the one named: a subscription that failed to apply because of FK constraint triggers GC

[linear]

VAX-1872 Possible issue in the new ShapeManager code.

[msfstef]

Thanks for reporting this! Indeed we had noticed that the AsyncEventEmitter was suppressing errors and we had a PR open to fix that (see #1247).

While working on that PR I managed to reproduce this error, you can see a description of what was happening here: #1247 (comment)

The above PR should also resolve this issue once merged.

[davidmartos96]

@msfstef I see, thanks!
We encountered this hidden error really by chance, as our Dart implementation wasn't doing the equivalent of Promise.waitSettled.