fix(client): Fix text encoding polyfill being fed numbers #1204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue raised in discord
The
TextEncoderLite
polyfill for the TextEncoder does not coerce its input to a string, and we force cast numbers withas string
in the encoding stage, resulting in the input being encoded as an empty bytearray.This does mean that the polyfill does not have the exact same behaviour as the original (which it should), but the immediate solution is to respect types and not force cast to a string when it isn't.