Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Commit

Permalink
Merge pull request #229 from electron/revert-228-no-whole-archive
Browse files Browse the repository at this point in the history
Revert "Replace --whole-archive with --start-group"
  • Loading branch information
zcbenz committed Jun 23, 2016
2 parents 8244628 + d81f886 commit 25d39ad
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions brightray.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,14 @@
'conditions': [
# Link with libraries of libchromiumcontent.
['OS=="linux" and libchromiumcontent_component==0', {
# On Linux we have to use "--start-group" or we will have plenty of
# On Linux we have to use "--whole-archive" to force executable
# to include all symbols, otherwise we will have plenty of
# unresolved symbols errors.
'link_settings': {
'libraries': [
'-Wl,--start-group',
'direct_dependent_settings': {
'ldflags': [
'-Wl,--whole-archive',
'<@(libchromiumcontent_libraries)',
'-Wl,--end-group'
'-Wl,--no-whole-archive',
],
}
}, { # (Release build on Linux)
Expand Down

0 comments on commit 25d39ad

Please sign in to comment.