New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace --whole-archive with --start-group" #229

Merged
merged 1 commit into from Jun 23, 2016

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented Jun 23, 2016

Reverts #228.
Closes electron/electron#6178.

It is causing crashes on Linux.

@zcbenz zcbenz merged commit 25d39ad into master Jun 23, 2016

@zcbenz zcbenz deleted the revert-228-no-whole-archive branch Jun 23, 2016

@tensor5

This comment has been minimized.

Contributor

tensor5 commented Jun 23, 2016

@zcbenz Are you sure #228 is the reason for electron/electron#6178? My build of Electron 1.2.4 on Linux works fine, and I've been using that patch even before it was merged.

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jun 23, 2016

@tensor5 Yeah I'm sure, not all Linux distributions are affected by this, but for those do, reverting this change can fix the crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment