fix: Attempt dynamically importing hook as a module if package.json `…

…type=module`, if fail, fallback to default `require` (#8042)
electron-userland · Feb 9, 2024 · 63a0044 · 63a0044
1 parent 94677f3
commit 63a0044
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/chilled-rats-provide.md b/.changeset/chilled-rats-provide.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+Attempt dynamically importing hook as a module if package.json `type=module`, if fail, fallback to default `require`
diff --git a/packages/app-builder-lib/src/platformPackager.ts b/packages/app-builder-lib/src/platformPackager.ts
@@ -756,8 +756,12 @@ export function normalizeExt(ext: string) {
 async function resolveModule<T>(type: string | undefined, name: string): Promise<T> {
   const extension = path.extname(name).toLowerCase()
   const isModuleType = type === "module"
-  if (extension === ".mjs" || (extension === ".js" && isModuleType)) {
-    return await eval("import('" + name + "')")
+  try {
+    if (extension === ".mjs" || (extension === ".js" && isModuleType)) {
+      return await eval("import('" + name + "')")
+    }
+  } catch (error) {
+    log.debug({ moduleName: name }, "Unable to dynamically import hook, falling back to `require`")
   }
   return require(name)
 }