fix: fixing downloadPromise not resolving on Mac. (#5802)

electron-userland · Apr 23, 2021 · d57453c · d57453c
1 parent 28cb86b
commit d57453c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/packages/electron-updater/src/MacUpdater.ts b/packages/electron-updater/src/MacUpdater.ts
@@ -122,14 +122,15 @@ export class MacUpdater extends AppUpdater {
               headers: { "Cache-Control": "no-cache" },
             })
 
-            this.nativeUpdater.once("error", reject)
-
             // The update has been downloaded and is ready to be served to Squirrel
             this.dispatchUpdateDownloaded(event)
 
             if (this.autoInstallOnAppQuit) {
+              this.nativeUpdater.once("error", reject)
               // This will trigger fetching and installing the file on Squirrel side
               this.nativeUpdater.checkForUpdates()
+            } else {
+              resolve([])
             }
           })
         })