-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How do I use the private github auto update feature? #1393
Comments
Hi @akorchev. You just need to set the N.B. private Github auto update is not yet working on Mac OSX, but I see you're on Windows so it should be fine |
Hi @AlienHoboken. Do you mean to set GH_TOKEN during build time? If yes - I was setting it but it wasn't being picked up when the application was running. I checked the implementation and it looks as if the application needs GH_TOKEN at runtime which I don't know how to set on the client machine. I ended up using setFeedUrl:
When I did that auto updates started working. BTW I tried on macOS and it also worked there. The only thing that didn't was starting the new version after the update was downloaded. But when I started it manually it was the latest version! Thanks for the great work! |
This provider ONLY if you have org and create DEDICATED user — only in this case you can share access token somehow. Otherwise you should use or proxy (#1370 (comment)), or s3. |
We should add note that private GitHub provider only for very special cases and not intended/suitable for all users. |
Does |
Why not use s3 in this case? because github storage is free? |
Yes. Use update: downside is that url |
The adoption of additional platforms is not preferred within the org. Also, can you use S3 with credentials through electron-updater? |
I suppose yes, since we use AWS SDK. You can set aws credentials env. But I am not sure. |
+1 That's why I didn't reject your PR :) |
@akorchev Did you ever get the NSIS installer working with Nuts? I've got a private repository, so I wanted to control distribution through Nuts. |
Yes, I did. Here is how I configured it (I am using the programming API): builder.build({
config: {
publish: [
{
provider: 'generic',
url: 'http://example.com/download'
},
{
provider: 'github'
}
], |
@akorchev Can you tell me about the use of the server when using Nuts to distribute the releases, please? Do you get any overload or everything just worked fine? |
Refs: - Testing auto updates electron-userland/electron-builder#3053 - electron-userland/electron-builder#1505 - electron-userland/electron-builder#1393
15.6.4
1.10.4
Windows 32 bit
How does one enable private github API support? It seems that GH_TOKEN is the only thing required but for some reason my app continues to make HTTP requests to the repo URL instead of api.github.com. Do I need to use
setFeedURL
?The text was updated successfully, but these errors were encountered: