Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference in CPU usage after Bundling #1970

Closed
fab1an opened this issue Aug 21, 2017 · 15 comments
Closed

Difference in CPU usage after Bundling #1970

fab1an opened this issue Aug 21, 2017 · 15 comments
Labels

Comments

@fab1an
Copy link

fab1an commented Aug 21, 2017

  • Version: 19.22.1
  • Target: mac

I have an application that displays a desktop-widget (frameless desktop window).
When I start electron directly everything works as it should.

When I package and sign the app using electron-builder performance drops.
Whenever I fiddle my mouse over the desktop I see the main-process using CPU in the Activity Monitor.

I tried profiling my app, but this ONLY occurs after packaging everything to an .app - bundle.

@develar
Copy link
Member

develar commented Aug 21, 2017

Interesting. Electron version? We use Electron original Info.plist as is (only meta like name and version are changed), so, issue is not clear for me.

@fab1an
Copy link
Author

fab1an commented Aug 21, 2017

Latest version from npm: 1.6.11

@develar
Copy link
Member

develar commented Aug 21, 2017

Latest stable is 1.7.5. Could you please update just to be sure?

@fab1an
Copy link
Author

fab1an commented Aug 21, 2017

Ah, I do have 1.7.5 ("Packaging for darwin x64 using electron 1.7.5 to dist/mac")

Just package.json reported the old version.

@develar
Copy link
Member

develar commented Aug 21, 2017

Unlikely I can help you. electron-builder doesn't touch any setting and doesn't try to customise something. You can send me app to check it on another machine.

If you use electron-is-dev (or similar approach) — check such places in your code. Try to don't use devtools or devtron (if you use) in the dev mode to check.

@develar
Copy link
Member

develar commented Aug 21, 2017

Is app signed?

@fab1an
Copy link
Author

fab1an commented Aug 21, 2017

I will try to make a test-case. Yes, the app is signed.

@develar
Copy link
Member

develar commented Aug 21, 2017

To be sure, try to test unsigned app.

@fab1an
Copy link
Author

fab1an commented Aug 22, 2017

Why did you close this?

@develar develar reopened this Aug 22, 2017
@develar
Copy link
Member

develar commented Aug 22, 2017

I cannot help you and want to keep issue list clear. If you want to keep this issue open to make visible for other users — ok, reopened.

@fab1an
Copy link
Author

fab1an commented Aug 22, 2017

Thanks, your choice. When I get around to the testcase I'll report what I find.

@develar
Copy link
Member

develar commented Aug 23, 2017

You can still send me your app to test on another machine to ensure, that it is not your local issue.

@fab1an
Copy link
Author

fab1an commented Aug 23, 2017

I haven't tracked down the bug, but I've verified that this occurs sometimes without electron-builder as well, so I'm closing this issue. Thank you for your quick help.

@fab1an fab1an closed this as completed Aug 23, 2017
@fab1an fab1an reopened this Sep 2, 2017
@fab1an fab1an closed this as completed Sep 2, 2017
@develar
Copy link
Member

develar commented Sep 5, 2017

@fab1an maybe related electron/electron#9413

@fab1an
Copy link
Author

fab1an commented Sep 5, 2017

My problem was: I had LSUIElement set in Info.plist to hude the dock icon.
In the signed build this somehow let to the transparent fullscreen browserwindow to never lose focus hence the cpu usage on mouseover.

I solved it by setting "focusable" to false on the BrowserWindow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants