Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too big raw data in the console #6131

Closed
NikolayMakhonin opened this issue Aug 8, 2021 · 1 comment · Fixed by #6143 or #6146
Closed

Too big raw data in the console #6131

NikolayMakhonin opened this issue Aug 8, 2021 · 1 comment · Fixed by #6143 or #6146

Comments

@NikolayMakhonin
Copy link

NikolayMakhonin commented Aug 8, 2021 •
edited
Loading

See please this line:

electron-builder/packages/electron-updater/src/NsisUpdater.ts

Line 157 in 39ac82f

throw new Error(`Cannot parse blockmap "${url.href}", error: ${e}, raw data: ${data}`)

The data is very big binary file (> 15 MB). Shrink please the data in error message to 1 KB
@mmaietta
Copy link
Collaborator

mmaietta commented Aug 9, 2021 •
edited
Loading

Just curious, is there a reason why we even need to log the raw data? I have no opposition to removing it.

mmaietta added a commit that referenced this issue Aug 11, 2021
@mmaietta
fix: console log data is far too large
bd66961 
Removing `data` from error being thrown. It's unnecessary and also unnecessarily large to be passing to the console
Resolves: #6131
@mmaietta mmaietta mentioned this issue Aug 11, 2021
Merged
@github-actions github-actions bot mentioned this issue Aug 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mmaietta @NikolayMakhonin