Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Electron.app #760

Closed
adammeyer opened this issue Sep 19, 2016 · 7 comments · May be fixed by qcif/data-curator#563
Closed

Custom Electron.app #760

adammeyer opened this issue Sep 19, 2016 · 7 comments · May be fixed by qcif/data-curator#563

Comments

@adammeyer
Copy link

  • Version: 6.7.7
  • Target: MacOS

I have a custom Electron.app I built manually (not using the Electron Prebuilt). It would be great if I could use Electron Builder somehow with this custom build.

@develar
Copy link
Member

develar commented Sep 19, 2016

Do you mean that you have own version of electron? I mean — electron-builder should somehow use your files instead of original from https://github.com/electron/electron/releases?

@adammeyer
Copy link
Author

Yes, I have my own version. Is there a way to tell Electron Builder to not use the prebuilt?

@develar
Copy link
Member

develar commented Sep 19, 2016

You can set ELECTRON_MIRROR environment variable to use a custom base URL for grabbing Electron zips (https://github.com/electron-userland/electron-download)

But I think, no rush, — I can add option tomorrow morning (CET). electronVersion will accept path to zip of your electron version (or just directory). Is it suitable for you?

@adammeyer
Copy link
Author

Yes, that should work great. Thank you!

@develar
Copy link
Member

develar commented Sep 19, 2016

Please specify what is more suitable for you — path to local directory (where files named in the same way as electron) or base http path? How do you distribute your electron version?

@adammeyer
Copy link
Author

Local directory

develar added a commit to develar/electron-builder that referenced this issue Sep 20, 2016
@develar
Copy link
Member

develar commented Sep 20, 2016

electronDist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants