Make electron-builder compatible with electron-nightly. #4473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nightly version of Electron is named "electron-nightly". Therefore, using the actual version, electron-builder cannot find it. This change is to make electron-builder compatible with the nightly builds.
Update the 7-zip optional dep with develar's latest build.
Try #1, dirty but should work
My bad, sorry.
This reverts commit 76c3d15.
This reverts commit 18e39fe.
|
@develar Can it be released as a pre-release? We would like to use the electron's nightly build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(as @develar asked, this is a clean PR)
The nightly version of Electron is named "electron-nightly". Therefore, using the actual version, electron-builder cannot find it.
This change is to make electron-builder compatible with the nightly builds.