Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the windows installer a module itself #1

Closed
stefanjudis opened this issue May 27, 2015 · 11 comments
Closed

Make the windows installer a module itself #1

stefanjudis opened this issue May 27, 2015 · 11 comments
Labels
feature

Comments

@stefanjudis
Copy link
Contributor

The MacOS dmg is created by appdmg.

Removing the logic for dealing with nsi and putting it into another module, would make electron-builder more testable and maintainable.

See - https://github.com/stefanjudis/winstaller
@justinmchase
Copy link

I'm looking at trying to get it to run on windows right now. It seems like moving appdmg to an optionalDependency allows it to install successfully on windows. I don't think that moving it to a separate project is necessary. Hopefully will have a pull request shortly.

@stefanjudis
Copy link
Contributor Author

Yeah it's more about putting complexity out to make the project easier to maintain.

But yeah - let's see where your PR brings us first. :)

@havenchyk
Copy link
Contributor

Is there any updates here?

@stefanjudis
Copy link
Contributor Author

Let's keep it like it is for now here. :)

@havenchyk
Copy link
Contributor

But what about the topic? Is there any result?

@stefanjudis
Copy link
Contributor Author

Well... yeah could be.
It might make sense to have a nsis installer module in npm out there.
But I have not the time to do that currently and electron-builder is running smoothly as it is right now. :)

@justinmchase
Copy link

@havenchyk The update was to make appdmg into an optional dependency and to then fix it up to work on windows. This now works on windows, but you do have to install nsis separately first and make sure its in your path.

@havenchyk
Copy link
Contributor

@justinmchase but what is better for windows: nsis or nuget? AFAIK, nuget is newer.

@justinmchase
Copy link

I haven't been apart of that discussion. As far as I know nuget doesn't build installers. But I've been out of the .net loop for a while so that could be a new thing. But anyway, I think you'd have to install nuget separately too. No?

@havenchyk
Copy link
Contributor

@justinmchase I'm just a newbie here and would like to create .msi and .dmg files for my app, nothing more :)

@justinmchase
Copy link

@havenchyk Well you're in the right place then I think. I don't think NuGet creates .msi's. nsis does, which is why you need it installed. This package essentially just drives nsis with a consistent cross-platform node-friendly api. But nsis does all the work.

This was referenced Mar 29, 2016
Closed
Closed
@stefanedberg stefanedberg mentioned this issue Nov 1, 2016
Closed
@ziedHamdi ziedHamdi mentioned this issue Dec 21, 2017
Closed
@myfrndjk myfrndjk mentioned this issue Jan 9, 2018
Closed
@baversjo baversjo mentioned this issue Mar 18, 2018
Closed
@soubhikchatterjee soubhikchatterjee mentioned this issue Jun 20, 2018
Closed
@andreborud andreborud mentioned this issue Jul 20, 2018
Closed
@KacyLuzz KacyLuzz mentioned this issue Jul 26, 2018
Closed
@jacklovepdf jacklovepdf mentioned this issue Oct 16, 2018
Closed
@Bendjen Bendjen mentioned this issue Jun 3, 2019
Closed
@VishnuPrabhuT VishnuPrabhuT mentioned this issue Oct 30, 2019
Closed
develar pushed a commit that referenced this issue Jan 16, 2020
@BellezaEmporium @develar
feat: Make electron-builder compatible with electron-nightly. (#4473)
35bff8c 
* Update electronVersion.ts

The nightly version of Electron is named "electron-nightly". Therefore, using the actual version, electron-builder cannot find it. 
This change is to make electron-builder compatible with the nightly builds.

* Update package.json

Update the 7-zip optional dep with develar's latest build.

* Update electronVersion.ts

Try #1, dirty but should work

* Update electronVersion.ts

My bad, sorry.

* Update electronVersion.ts

?

* Update electronVersion.ts

Hmm.

* Update electronVersion.ts

* Update electronVersion.ts

* Update electronVersion.ts

* Update electronVersion.ts

* Update electronVersion.ts

* Update electronVersion.ts

* Update electronVersion.ts

* Update electronVersion.ts

* Update electronVersion.ts

* Fixing for test

* Updated all deps

* Revert "Updated all deps"

This reverts commit 76c3d15.

* Revert "Update package.json"

This reverts commit 18e39fe.
@ifzm ifzm mentioned this issue Mar 14, 2020
Closed
@msi008 msi008 mentioned this issue Aug 7, 2020
Closed
bedney added a commit to TechnicalPursuit/electron-builder that referenced this issue Aug 18, 2020
@bedney
Trying to debug the config schema problem electron-userland#1
2a980c1
@532604872 532604872 mentioned this issue Feb 3, 2021
Closed
@mmaietta mmaietta mentioned this issue Jun 16, 2021
Closed
Closed
ppd added a commit to ppd/electron-builder that referenced this issue Dec 3, 2021
@ppd
changes for electron-userland#6201 (electron-userland#1)
0bddd6d 
* use new app-builder-bin & hook up compression option

* set default snap compression type to lzo
@budowski budowski mentioned this issue Oct 20, 2022
Closed
@iotzy iotzy mentioned this issue Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justinmchase @stefanjudis @havenchyk