fix(nsis): Ignore other users processes #6472
Conversation
Only find and kill processes owned by current user on install. On per-user installation, other users run their own copy of the app. These instances will not block install and are should be left untouched. fixes electron-userland#6104
Change to not relying on taskkill's return value. taskkill returns 0 when at least one process is killed even if there are any other process not killed.
🦋 Changeset detectedLatest commit: d602e1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Just a quick FYI, we are investigating a report from a person on Windows 10 Education being unable to update. So far everything indicates that this commit might be the culprit. I have a feeling that the Education version of Windows may come without some of the command-line tools, but I'm yet to confirm this. |
|
@indutny-signal |
|
@I-Otsuki I think the code is correct and I honestly updated dozens of times myself on both Windows 10 and Windows 11 before we shipped it to users. We have a number of reports from people running into this and so far it looks like it is a small percentage of users, but it is far from a singular event as far as I can tell. Unfortunately, we had another unrelated issue with yellow banner so things are bit confusing in the bug tracker now. |
Only find and kill processes owned by current user on per-user install.
Closes #6104