Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to Ubuntu 22.04 and python 3.10 #6922

Merged

Conversation

relativisticelectron
Copy link
Contributor

@relativisticelectron relativisticelectron commented Jun 4, 2022

feat: Upgrade to Ubuntu 22.04 and python 3.10

See: #6898

@changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2022

🦋 Changeset detected

Latest commit: 36dc540

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jun 4, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 36dc540
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/629d0511be39c300084d36c1
😎 Deploy Preview https://deploy-preview-6922--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@relativisticelectron
Copy link
Contributor Author

relativisticelectron commented Jun 4, 2022

npx changeset gives an error and I cannot get it to run to create the changeset file.

@mmaietta mmaietta changed the title Upgrade to Ubuntu 22.04 and python 3.10 feat: Upgrade to Ubuntu 22.04 and python 3.10 Jun 5, 2022
@relativisticelectron
Copy link
Contributor Author

@mmaietta Thanks for adding the changeset.

@mmaietta mmaietta merged commit 03cc9b9 into electron-userland:master Jun 7, 2022
@mmaietta
Copy link
Collaborator

mmaietta commented Jun 7, 2022

Thanks for your contribution!

@relativisticelectron relativisticelectron deleted the upgrade_to_2204 branch June 11, 2022 06:53
@relativisticelectron
Copy link
Contributor Author

Thanks for your help and merging it.

@relativisticelectron
Copy link
Contributor Author

relativisticelectron commented Aug 25, 2022

@mmaietta : Is there any timeline when the new version will be pushed to https://hub.docker.com/r/electronuserland/builder/tags ?

@mmaietta
Copy link
Collaborator

Whoops! My bad.
Just pushed the image now. Needed to add a git tag to trigger the auto-deployment

@mmaietta
Copy link
Collaborator

@relativisticelectron , soooo this new images seems to have broken a few things. Can you please take a look as soon as possible? Otherwise I'll need to delete the new images.

#7092
#7101
#7102

@relativisticelectron
Copy link
Contributor Author

relativisticelectron commented Aug 31, 2022

@relativisticelectron , soooo this new images seems to have broken a few things. Can you please take a look as soon as possible? Otherwise I'll need to delete the new images.

#7092 #7101 #7102

Uhh... I looked at all 3 issues.

I would suggest you restore the original docker image for now 😢 . Is there a way to deploy electron Ubuntu 22.04 docker images (under a different tag), such that people have time to slowly solve upgrade issues?

@mmaietta
Copy link
Collaborator

mmaietta commented Sep 1, 2022

So, due to the way the docker images were previously set up, they're keyed off of the year+month, so ironically, I can't override the images anymore as it's a new month lol. I'll revert the other PR, but it'll keep your current version available for you to debug further with. They'll all have the suffix 08.22 while latest tag will be the previous implementation
14-wine-mono-08.22

relativisticelectron added a commit to relativisticelectron/specter-desktop that referenced this pull request Sep 3, 2022
k9ert added a commit to cryptoadvance/specter-desktop that referenced this pull request Sep 13, 2022
* changed class name

* Working requirements.in

* Reordered lines to see changes better

* Working minimal upgrades

* Added hashes

* - Upgraded python to 3.10 and bitcoin to v23.0
- Added libzmq to build process, to enable future use cases such as #778
- added --without-gui to remove configure warning that gui will not be built.

* Added line-break

* - Updated the embit version to 0.4.13
- pushed python-bitcoind image

* - Build registry.gitlab.com/c8527/specter/cirrus-jammy:20220504
- updated docker references

* - added cypress-base-ubuntu-jammy

* - added cypress-python

* - fixed unchanged registry path

* Fixed wrong path

* readme change

* Fixed path

* Changed github-changelog

* changes registrar links

* Fixed bitcoin version

* Set reset bitcoin version to 22

* Set bitcoin version to 22.0

* Fixed black issue via psf/black#2964 (comment)

* Revert for changelog

* Upgraded pytest because otherwise I get the error  pytest-dev/pytest#9195

* Added temporary fix for upgraded hwi version. Should be fixed in #1693

* more verbosity for page generation

* doc about python 3.10

* docs: update TOC

* yet another library necessary

* black

* Corrected tag

* Fixed wrong python version introduced in the merge commit

* Use same babel version across requirements and test_requirements

* Created the reuqirements.txt with python 3.8 such, that that netlify can create the python docs in python 3.8, while everything elese works also with python 3.10

* testing https://peps.python.org/pep-0508/#environment-markers

* CHanged just the txt

* Added comments

* electron docker build successful

* rename image to cypress-python:v9.7.0

* doc

* docker file rename

* fix pyinstaller pip error by changing requirements.in

* reference jammy electron dockerfile

See electron-userland/electron-builder#6922 (comment)

* updated all references to dockerimages

* fix release-build

* fix the image-version to something else than latest. pin all the stuff!

* revert to old image to avoid glibc issues

Co-authored-by: Kim Neunert <k9ert@gmx.de>
Co-authored-by: k9ert <k9ert@users.noreply.github.com>
@garrisig
Copy link

garrisig commented Apr 5, 2023

Maybe the errors were due to the wrong codename used: Ubuntu 22.04 is jammy, not impish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants