Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): clarify yalc setup instructions #7498

Merged

Conversation

NoahAndrews
Copy link
Contributor

The publish and link commands were grouped together, even though they needed to be run from entirely different locations.

The publish and link commands were grouped together, even
though they needed to be run from entirely different locations.
@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2023

⚠️ No Changeset found

Latest commit: 8f431f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 24, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 8f431f9
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/641df6c2b8f4300008a4d8f3
😎 Deploy Preview https://deploy-preview-7498--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta mmaietta changed the title Clarify yalc setup instructions chore(docs): clarify yalc setup instructions Mar 24, 2023
@NoahAndrews
Copy link
Contributor Author

Hmm, the Powershell script to apply changes to the yalc script is also broken.

@mmaietta
Copy link
Collaborator

@NoahAndrews I actually don't know how PowerShell works tbh. I believe that was a community contribution

@NoahAndrews
Copy link
Contributor Author

It was a simple error that's now fixed in this PR.

@mmaietta mmaietta merged commit 2602331 into electron-userland:master Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants