Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

Probot Client should be able to update its own comment #97

Closed
ckerr opened this issue Jul 4, 2021 · 0 comments · Fixed by #109
Closed

Probot Client should be able to update its own comment #97

ckerr opened this issue Jul 4, 2021 · 0 comments · Fixed by #109
Assignees
Labels
module:bot ✨ enhancement New feature or request

Comments

@ckerr
Copy link
Member

ckerr commented Jul 4, 2021

Right now the probot client's workflow for bisect is

  1. start bisect
  2. wait for bisect to finish
  3. give the results in a new comment

Instead, it should be:

  1. add a comment saying that the bisect is beginning
  2. start bisect
  3. wait for bisect to finish
  4. give the results by updating the comment created in step 1

The bot should be refactored in a way s.t. it should not care whether the first comment exists yet or not, e.g. GithubClient.setBugbotComment(markdown: string) (or whatever function name) so that the comment is created if it doesn't exist, or updated if it does exist.

We will need this functionality for the matrix as well, but adding it for the existing bisect feature means it could be developed now before the matrix code is ready.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module:bot ✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants