Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons should update labels correctly #35

Closed
MarshallOfSound opened this issue Dec 3, 2020 · 0 comments · Fixed by #41
Closed

Buttons should update labels correctly #35

MarshallOfSound opened this issue Dec 3, 2020 · 0 comments · Fixed by #41
Assignees
@MarshallOfSound

Comments

@MarshallOfSound
Copy link
Member

If the new-pr label is not present.

LGTM / Request changes should:

  • Check if > 2 approved and exactly 0 people requested changes
    • If so, add api-review/approved label
    • If not, ensure api-review/requested label is present

If new-pr is present, ensure api-review/requested is the current label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarshallOfSound MarshallOfSound

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update labels when new-pr is gone electron/cation
1 participant
@MarshallOfSound