alert re-enable maximizable even if set to false

[pinkladywithcoco]

Development environment:

I’m using Electron version: 1.7.11

on the following operating systems:

macOS Sierra version 10.12.6

64-bit Windows 10

Expected behaviour:

The maximize button get disabled and stays disabled until we enable it again ourself.

Actual behaviour:

The maximize button get disabled, but re-enabled itself if some alert get fired.

How to reproduce:

If i create a window like this:

win = new BrowserWindow({ title: "My App", backgroundColor:'#FF0000', maximizable:false, width: 400, height: 200, resizable: false})

The window maximize button get disabled as wanted, but if we active the alert function inside

the index.html file by putting <script> alert("test"); </script> inside the file then the maximize button get enabled again and we can use it again.

The maximize should stay disabled. This must be a bug happening on both platform. I Have not tested on Linux.

[welcome]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

[sofianguy]

Thanks for reaching out!

We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.

Thanks for understanding and meeting us half way 😀

[pinkladywithcoco]

Hi! i have updated my bug report to include the steps :-)

[nikita-graf]

Reproduceable in electron@1.8.2 on macOS 10.13.3.

[enuoCM]

Hi, is any update on this issue? Thanks.
Now I have to setMaximizable(false) again after alert dialog dismissed.

[sofianguy]

Thank you for taking the time to report this issue and helping to make Electron better.

The version of Electron you reported this on has been superseded by newer releases.

If you're still experiencing this issue in Electron v2.0.x or later, please add a comment specifying the version you're testing with and any other new information that a maintainer trying to reproduce the issue should know.

I'm setting the blocked/need-info label for the above reasons.

Thanks in advance! Your help is appreciated.

[sofianguy]

Thank you for your issue!

We haven't gotten a response to our questions in our comment above. With only the information that is currently in the issue, we don't have enough information to take action. I'm going to close this but don't hesitate to reach out if you have or find the answers we need, we'll be happy to reopen the issue.

[RoderickQiu]

I've made another issue of this.
#22646
thank you if there are solutions

---

Hey I just found out that this issue is still here, with 7.1.14, on macOS 10.14.3.
Any help here?

The step to reproduce is still

If i create a window like this:

win = new BrowserWindow({ title: "My App", backgroundColor:'#FF0000', maximizable:false, width: 400, height: 200, resizable: false})

The window maximize button get disabled as wanted, but if we active the alert function inside

the index.html file by putting <script> alert("test"); </script> inside the file then the maximize button get enabled again and we can use it again.

These are extremely old resources that I found:

• Always restore maximizable state after changing window behavior/style #6736
• fix: respect minimizable/closable for customButtonsOnHover #18425

Also, for other kinds of code, like

nativeTheme.on('updated', function theThemeHasChanged() {
    if (nativeTheme.shouldUseDarkColors) {
      if (mainWindow != null) {
        mainWindow.setBackgroundColor('#393939');
      }
    } else {
      if (mainWindow != null) {
        mainWindow.setBackgroundColor('#fefefe');
      }
    }
  })

can also produce this problem.