fix: respect minimizable/closable for customButtonsOnHover #18425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #18364.
This PR ameliorates an issue whereby
minimizable
andclosable
weren't respected incustomButtonsOnHover
mode.maximizable
isn't addressable here, since it's been blanket disabled in newer versions of macOS owing to an issue with theNSWindowStyleMaskFullSizeContentView
style mask. That will, however, be addressed in the relevant backport pull request.This can be backported to 6 as-is but will need to be manually backported to 5 & 4 to account for the
maximizable
consideration.cc @pronebird @MarshallOfSound @nornagon @miniak
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue whereby
minimizable
andclosable
weren't respected incustomButtonsOnHover
mode.