auto re-enable maximizable even if set to false

[RoderickQiu]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for an issue that matches the one I want to file, with only a solution not working alert re-enable maximizable even if set to false #11756.

Issue Details

• Electron Version:
  • 7.1.14
• Operating System:
  • macOS 10.15.2

Expected Behavior

maximizable property should always work.

Actual Behavior

maximizable property will be ignored when some other properties are changed to the window or an alert is shown.

To Reproduce

From #11756.

If i create a window like this:

win = new BrowserWindow({ title: "My App", backgroundColor:'#FF0000', maximizable:false, width: 400, height: 200, resizable: false})

The window maximize button get disabled as wanted, but if we active the alert function inside

the index.html file by putting <script> alert("test"); </script> inside the file then the maximize button get enabled again and we can use it again.

Also, for other kinds of code, like

var mainWindow = new BrowserWindow({
    width: 800,
    height: 600,
    maximizable: false,
    webPreferences: {
      nodeIntegration: true
    }
  })

nativeTheme.on('updated', function theThemeHasChanged() {
    if (nativeTheme.shouldUseDarkColors) {
      if (mainWindow != null) {
        mainWindow.setBackgroundColor('#393939');
      }
    } else {
      if (mainWindow != null) {
        mainWindow.setBackgroundColor('#fefefe');
      }
    }
  })

can also produce this problem.
(how to: set dark mode / light mode, and then maximizable property is ignored.)

Additional Information

These are extremely old resources that I found:

• Always restore maximizable state after changing window behavior/style #6736
• fix: respect minimizable/closable for customButtonsOnHover #18425

[codebytere]

@RoderickQiu some research tells me this is becuase the maximizable setting does not persist through an NSWindow redraw event, which is triggered when a user changes between light and dark modes as discussed here:

When the user changes the system appearance, the system automatically asks each window and view to redraw itself.

I'll see what i can do.

[RoderickQiu]

OK thank you. I'll wait.

Though this problem doesn't only appear for dark mode changes. (But to solve one of trigger condition is good too.)

Is this problem here for many conditions because many functions need a redraw?

[codebytere]

@RoderickQiu fix for the theme change issue is up - the alert issue may lie with Chromium unfortunately though