Regression: Invisible menu items no longer work via their accelerator keys

[stephenmartindale]

With Electron 1.8, it was possible to create an invisible menu item in the application menu and, assuming it was still enabled, it could be invoked via its accelerator key. This provided a mechanism for creating application-wide shortcut keys that were independent from content.

For example, this menu-item template worked just fine:

            {
                visible: false,
                accelerator: "F12",
                click: () => {
                    mainWindow.webContents.openDevTools({ mode: "detach" });
                }
            },

Since upgrading to Electron2.0.0-beta.1, this no longer works. Instead, I have to make the menu item visible and give it a name in order for it to be triggered by its accelerator key:

            {
                visible: true,
                label: "Developer Tools",
                accelerator: "F12",
                click: () => {
                    mainWindow.webContents.openDevTools({ mode: "detach" });
                }
            },

Is this just a regression or is this by design? If it is by design, is there any way to achieve window-level shortcut keys without resorting to nasty keydown and keyup handlers on the content level?

[welcome]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

[codebytere]

@stephenmartindale what platform was this on?

[stephenmartindale]

It was Windows 10.0.16299, x64.

…

On 1 April 2018 at 06:05, Shelley Vohr ***@***.***> wrote: @stephenmartindale <https://github.com/stephenmartindale> what platform was this on? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12025 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGEzYQQhkaJ_8OlVimCdhpRdglG7ARuKks5tkFIHgaJpZM4SQ82m> .

[abnerlee]

I can also reproduce this on Windows

[stephenmartindale]

FYI: I tested this on 2.0.0-beta.8, today, on Windows 10, and the bug is still present.

[codebytere]

i can take a look at this next week!

[codebytere]

@stephenmartindale verdict is that this happened as a result of some separator filtering i implemented; i'll see if i can open a PR to remedy this side effect.