Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron window does not appear with Node.js v11.0.0 #15467

Closed
dojyorin opened this issue Oct 30, 2018 · 3 comments · Fixed by #15469
Closed

Electron window does not appear with Node.js v11.0.0 #15467

dojyorin opened this issue Oct 30, 2018 · 3 comments · Fixed by #15469

Comments

@dojyorin
Copy link

  • electron@4.0.0-beta.5
  • Windows 7 Professional 32bit
  • node v11.0.0

Behavior

# CommandPrompt

> electron
Electron 4.0.0-beta.5 - Build cross platform desktop apps with JavaScript, HTML,
 and CSS
Usage: electron [options] [path]

A path to an Electron app may be specified. It must be one of the following:
  - index.js file.
  - Folder containing a package.json file.
  - Folder containing an index.js file.
  - .html/.htm file.
  - http://, https://, or file:// URL.

Options:
  -i, --interactive     Open a REPL to the main process.
  -r, --require         Module to preload (option can be repeated).
  -v, --version         Print the version.
  -a, --abi             Print the Node ABI version.

After this, the focus is out of the CMD window, but Electron window does not appear.

Cause

Node.js v11.0.0 later, the default for the windowsHide option has become true.

As a result, it will be activated in hidden state with proc.spawn () in cli.js.

// node_modules/electron/cli.js
var child = proc.spawn(electron, process.argv.slice(2), { stdio: 'inherit' })

To Fix

// node_modules/electron/cli.js
var child = proc.spawn(electron, process.argv.slice(2), { stdio: 'inherit', windowsHide: false })

Could you please fix the branch?
Thank you.

@welcome
Copy link

welcome bot commented Oct 30, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@CephalonCosmic
Copy link

I have the same issue with

  • electron@2.0.12
  • Windows 10 Home 64bit - v1803
  • Node v11.0.0

@dojyorin
Copy link
Author

@MarshallOfSound Thank you for quick support! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants