-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandbox inside ppapi don't inherit sanbox property from BrowserWindow #18516
Comments
@Feverqwe Why is that a problem? |
@miniak cause ppapi plugins don't works. I can't disable sandbox for window, I can only disable it globally. |
@Feverqwe which plugin? The only plugins that would not work with sandbox are host-native ones built as plain DLL that don't exclusively use the Pepper API. |
I use mpv.js from here https://github.com/Kagami/mpv.js |
code example would be
|
Its looks great! Thx! |
@Feverqwe the only problem is that this is semver minor and we'll be only able to add this to Electron 6, which is still in beta. For Electron 5, we would have to bump 5.0 to 5.1 in order to add a new API there. |
@miniak its not a problem for me. I resolve this problem via switch, after release I will use this api method. |
Closing this issue as it is reported to be fixed. Feel free to reach out if you are still experiencing this issue in later versions of Electron and we can reopen. |
Hello. I run BrowserWindow with sandbox false and when run ppapi plugin inside, it runing inside sandbox.
Preflight Checklist
Issue Details
Expected Behavior
ppapi process must inheret --no-sandbox switch
Actual Behavior
ppapi process don't inheret --no-sandbox switch when BrowserWindow have sandbox: false property.
To Reproduce
Create window and run any ppapi plugin inside
Additional Information
I can fix it with this switch, but is disable sandbox globally.
The text was updated successfully, but these errors were encountered: