Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrome.runtime's port.postMessage incorrectly send UintArray #19070

Closed
3 tasks done
kwonoj opened this issue Jul 1, 2019 · 0 comments · Fixed by #19104
Closed
3 tasks done

chrome.runtime's port.postMessage incorrectly send UintArray #19070

kwonoj opened this issue Jul 1, 2019 · 0 comments · Fixed by #19104
Assignees
@MarshallOfSound
Labels
5-0-x bug 🪲 platform/macOS
Projects
5.0.x

Comments

@kwonoj
Copy link
Contributor

kwonoj commented Jul 1, 2019

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version: 5.0.6
  • Operating System: mac OS 10.14.5
  • Last Known Working Electron version: Unknown

Expected Behavior

port.postMessage correctly send UintArray

Actual Behavior

port.postMessage incorrectly appends unexpected number of 0 in buffer

To Reproduce

Screenshots

from Electron@5
image

from chrome browser
image

Additional Information

bvaughn/react-devtools-experimental#344 is caused by this, since every postMessage to UnitArray appends 0 to its buffer, operations relying on 0 as default value (unsupported) raises exception on devtools.

As attached above, this only happens in Electron (4 / 5 both so far tried) but not occurring on Chrome.
@kwonoj kwonoj changed the title chrome.runtime's port.postMessage incorrectly transfer UintArray chrome.runtime's port.postMessage incorrectly send UintArray Jul 1, 2019
@sofianguy sofianguy added this to Unsorted Issues in 5.0.x Jul 2, 2019
@MarshallOfSound MarshallOfSound self-assigned this Jul 3, 2019
MarshallOfSound added a commit that referenced this issue Jul 3, 2019
@MarshallOfSound
fix: serialize messages being sent over chrome message ports
205ff77 
Chrome appears to serialize these messages (see #19070) so we should as
well to be consistent and to avoid bugs with Uint8/16 arrays

Fixes #19070
This was referenced Jul 3, 2019
Merged
Merged
trop bot pushed a commit that referenced this issue Jul 15, 2019
@MarshallOfSound @electron-bot
fix: serialize messages being sent over chrome message ports
3e92bc4 
Chrome appears to serialize these messages (see #19070) so we should as
well to be consistent and to avoid bugs with Uint8/16 arrays

Fixes #19070
zcbenz pushed a commit that referenced this issue Jul 15, 2019
@MarshallOfSound @zcbenz
fix: serialize messages being sent over chrome message ports (#19104)
6d5e494 
Chrome appears to serialize these messages (see #19070) so we should as
well to be consistent and to avoid bugs with Uint8/16 arrays

Fixes #19070
codebytere pushed a commit that referenced this issue Jul 16, 2019
@trop @codebytere
fix: serialize messages being sent over chrome message ports (#19252)
019e605 
Chrome appears to serialize these messages (see #19070) so we should as
well to be consistent and to avoid bugs with Uint8/16 arrays

Fixes #19070
@sofianguy sofianguy moved this from Unsorted Issues to Fixed for Next Release in 5.0.x Jul 16, 2019
@sofianguy sofianguy moved this from Fixed for Next Release to Fixed in 5.0.10 in 5.0.x Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarshallOfSound MarshallOfSound

Labels
5-0-x bug 🪲 platform/macOS
Projects
No open projects
5.0.x
Fixed in 5.0.10
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: serialize messages being sent over chrome message ports electron/electron
3 participants
@kwonoj @sofianguy @MarshallOfSound