-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BrowserWindow extension API is not available on ready
since 9
#23656
Labels
Comments
Also the docs should probably be updated to point to |
bendemboski
added a commit
to adopted-ember-addons/ember-electron
that referenced
this issue
May 20, 2020
Unfortunately, due to bugs in Electron 9, we can't use devtron (electron/electron#23676). We could at least get Ember Inspector to load (using the workaround for electron/electron#23656), but hopefully Electron will turn around a quick fix at least for that second issue so we don't have to add a temporary workaround to the blueprint-generated code...
To anyone reading this: this affects just the compatibility wrapper. The correct "work-around" is not to wrap this call in |
bendemboski
added a commit
to adopted-ember-addons/ember-electron
that referenced
this issue
May 21, 2020
Unfortunately, due to bugs in Electron 9, we can't use devtron (electron/electron#23676). We could at least get Ember Inspector to load (using the workaround for electron/electron#23656), but hopefully Electron will turn around a quick fix at least for that second issue so we don't have to add a temporary workaround to the blueprint-generated code...
bendemboski
added a commit
to adopted-ember-addons/ember-electron
that referenced
this issue
May 21, 2020
Unfortunately, due to bugs in Electron 9, we can't use devtron (electron/electron#23676). We could at least get Ember Inspector to load (using the workaround for electron/electron#23656), but hopefully Electron will turn around a quick fix at least for that second issue so we don't have to add a temporary workaround to the blueprint-generated code...
Let's close this as those were removed in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Preflight Checklist
There were some similar, e.g. TypeError: BrowserWindow.addDevToolsExtension is not a function #22117, but my issue is not reproducible on 8.x.
Issue Details
Linux xps 5.6.11-arch1-1 #1 SMP PREEMPT Wed, 06 May 2020 17:32:37 +0000 x86_64 GNU/Linux
(Arch Linux Current)Expected Behavior
Extension APIs should be available on
BrowserWindow
on appready
event, as documented.Actual Behavior
Extension APIs are not available on app
ready
event but become available after a delay.To Reproduce
Results:
The text was updated successfully, but these errors were encountered: