Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtron will not load in 9.0.0 #23676

Closed
3 tasks done
bendemboski opened this issue May 20, 2020 · 4 comments
Closed
3 tasks done

Devtron will not load in 9.0.0 #23676

bendemboski opened this issue May 20, 2020 · 4 comments

Comments

@bendemboski
Copy link

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 9.0.0
  • Operating System:
    • MacOS
  • Last Known Working Electron version:
    • 8.3.0

Expected Behavior

Running require('devtron').install() from the renderer process console or main process successfully installs the devtron extension

Actual Behavior

If run from the main process it fails with:

(node:52975) UnhandledPromiseRejectionWarning: Error: Loading extension at /private/tmp/foo/node_modules/devtron failed with: The 'manifest_version' key must be present and set to 2 (without quotes). See developer.chrome.com/extensions/manifestVersion.html for details.
(node:52975) UnhandledPromiseRejectionWarning: Error: Loading extension at /private/tmp/foo/node_modules/devtron failed with: The 'manifest_version' key must be present and set to 2 (without quotes). See developer.chrome.com/extensions/manifestVersion.html for details.

and similar if it is run from the renderer process' console

To Reproduce

Run yarn init -y && yarn add --dev electron@9 devtron. Put this in index.js:

const { app, BrowserWindow } = require('electron')

function createWindow () {
  // setImmediate() to work around https://github.com/electron/electron/issues/23656
  setImmediate(() => require('devtron').install());

  // Create the browser window.
  let win = new BrowserWindow({
    width: 800,
    height: 600,
    webPreferences: {
      nodeIntegration: true
    }
  })

  // and load the index.html of the app.
  win.loadFile('index.html')
}

app.whenReady().then(createWindow)

Run yarn electron . and observe the error in the console. Open the devtools console in the browser window and run require('devtron').install() -- same result.

bendemboski added a commit to adopted-ember-addons/ember-electron that referenced this issue May 20, 2020
Unfortunately, due to bugs in Electron 9, we can't use devtron (electron/electron#23676). We could at least get Ember Inspector to load (using the workaround for electron/electron#23656), but hopefully Electron will turn around a quick fix at least for that second issue so we don't have to add a temporary workaround to the blueprint-generated code...
bendemboski added a commit to adopted-ember-addons/ember-electron that referenced this issue May 21, 2020
Unfortunately, due to bugs in Electron 9, we can't use devtron (electron/electron#23676). We could at least get Ember Inspector to load (using the workaround for electron/electron#23656), but hopefully Electron will turn around a quick fix at least for that second issue so we don't have to add a temporary workaround to the blueprint-generated code...
bendemboski added a commit to adopted-ember-addons/ember-electron that referenced this issue May 21, 2020
Unfortunately, due to bugs in Electron 9, we can't use devtron (electron/electron#23676). We could at least get Ember Inspector to load (using the workaround for electron/electron#23656), but hopefully Electron will turn around a quick fix at least for that second issue so we don't have to add a temporary workaround to the blueprint-generated code...
@miniak
Copy link
Contributor

miniak commented May 26, 2020

Please report to https://github.com/electron-userland/devtron/issues

@miniak miniak closed this as completed May 26, 2020
@bendemboski
Copy link
Author

@miniak any clue on what changed on the Electron/Chromium side that might have started causing this failure in 9.x to tell the Devtron folks?

@jphw
Copy link

jphw commented May 29, 2020

@miniak devtron repo is pretty much dead, no commits since 2018. so imo it's Electron team who should fix the issue since devtron worked fine before E9

@Nantris
Copy link
Contributor

Nantris commented Jan 31, 2021

"WARNING: Devtron is currently unmaintained."

If https://www.electronjs.org/devtron is going to stay live then I think that Devtron issues should not be ignored by the Electron team, especially since this issue persists.

If it's only usable on versions of Electron the team no longer supports, then I think that page should be removed, or at least make obvious note of that. It's currently listed as, "Official DevTools extension." but that seems not to be the case.

Devtron was (is) a crucial tool and to lose it just when Electron starts really moving everyone towards IPC communications is a major loss for developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants