fix: Don't ignore the referer header in net.request #23686

zeeker999 · 2020-05-20T21:49:02Z

Backport of #23386

See that PR for details.

Notes: Don't ignore the referrer header in net.request

…ains (electron#21580) * fix: set enable_negotiate_port to false in allowNTLMCredentialsForDomains * read commandline switch Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>

* chore: bump chromium in DEPS to 80.0.3987.16 * chore: bump chromium in DEPS to 80.0.3987.18 * chore: bump chromium in DEPS to 80.0.3987.20 * chore: bump chromium in DEPS to 80.0.3987.21 * chore: bump chromium in DEPS to 80.0.3987.22 * chore: bump chromium in DEPS to 80.0.3987.23 * chore: bump chromium in DEPS to 80.0.3987.24 * chore: bump chromium in DEPS to 80.0.3987.25 * chore: bump chromium in DEPS to 80.0.3987.26 * chore: bump chromium in DEPS to 80.0.3987.27 * chore: bump chromium in DEPS to 80.0.3987.28 * chore: bump chromium in DEPS to 80.0.3987.29 * chore: bump chromium in DEPS to 80.0.3987.30 * chore: bump chromium in DEPS to 80.0.3987.31

…rted (electron#21685)

* chore: bump chromium in DEPS to 80.0.3987.32 * chore: bump chromium in DEPS to 80.0.3987.33 * chore: bump chromium in DEPS to 80.0.3987.34 * chore: bump chromium in DEPS to 80.0.3987.36 * chore: bump chromium in DEPS to 80.0.3987.37 * chore: bump chromium in DEPS to 80.0.3987.38 * chore: bump chromium in DEPS to 80.0.3987.39 * chore: bump chromium in DEPS to 80.0.3987.40 * chore: bump chromium in DEPS to 80.0.3987.43 * chore: bump chromium in DEPS to 80.0.3987.47

…21735) * fix: reset next/prev pointers for life-monitored nodes * fix: don't double-delete nodes in a linked list Co-authored-by: loc <andy@slack-corp.com>

) Co-authored-by: Milan Burda <milan.burda@gmail.com>

…on#21431)

Co-authored-by: loc <andy@slack-corp.com>

Co-authored-by: Shelley Vohr <codebytere@github.com>

…ayerHost (8-x-y) (electron#21574) * fix: add patch to disable remote accessibility APIs * fix: add patch to disable private window frame APIs

* chore: bump chromium in DEPS to 80.0.3987.49 * chore: bump chromium in DEPS to 80.0.3987.50 * chore: bump chromium in DEPS to 80.0.3987.51

Backports https://chromium-review.googlesource.com/c/v8/v8/+/1967317

Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>

* fix: pass full response headers in net module * chore: put helper classes in annoymouse namespace * fix: use hasOwnProperty to test key * chore: shorter class name Co-authored-by: Cheng Zhao <zcbenz@github.com>

Co-authored-by: Shelley Vohr <codebytere@github.com>

…ds in the dictionary (electron#21297) * feat: add session.addWordToSpellCheckerDictionary to allow custom words in the dictionary * Update session.md Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>

* chore: cherry-pick 38990b7d56e6 from chromium * update patches Co-authored-by: Electron Bot <anonymous@electronjs.org>

…lectron#23542) Co-authored-by: John Kleinschmidt <jkleinsc@github.com>

Co-authored-by: Andrey Belenko <anbelen@microsoft.com>

…on#23552) Co-authored-by: Samuel Attard <sattard@slack-corp.com>

* chore: cherry-pick 7101418f85a0 from chromium * update patches Co-authored-by: Electron Bot <anonymous@electronjs.org> Co-authored-by: Andrey Belenko <anbelen@microsoft.com>

It can cause build failures because the header is generated and there's no explicit dependency on a target that creates it. Co-authored-by: Aleksei Kuzmin <alkuzmin@microsoft.com>

…ory manage (electron#23592) (electron#23612)

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

electron-bot and others added 30 commits December 18, 2019 14:04

Bump very far --> this is electron bot fixing the release

28e44b3

build: free up macos disk space on Mac publish (electron#21570)

f5ce5f8

fix: set enable_negotiate_port to false in allowNTLMCredentialsForDom…

7e8c110

…ains (electron#21580) * fix: set enable_negotiate_port to false in allowNTLMCredentialsForDomains * read commandline switch Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>

fix: highlight defaulted button correctly (electron#21653)

6856658

fix: SimpleURLLoaderWrapper redirects (electron#21566) (electron#21644)

64e48ad

refactor: throw error for getLastCrashReport if crashReporter not sta…

37592cd

…rted (electron#21685)

fix: Notification crash in before-quit (electron#21720)

fa7326a

fix: don't unnecessarily copy draggable regions (electron#21722)

2c92573

chore: bump chromium in DEPS to 80.0.3987.48 (electron#21728)

c6517c0

fix: avoid contextBridge double free on garbage collection (electron#…

da45f03

…21735) * fix: reset next/prev pointers for life-monitored nodes * fix: don't double-delete nodes in a linked list Co-authored-by: loc <andy@slack-corp.com>

chore: deprecate visibleOnFullScreen option (electron#21732)

ee65a19

docs: responseHeaders should be Record<string, string[]> (electron#21743

6faef05

) Co-authored-by: Milan Burda <milan.burda@gmail.com>

fix: load window-setup in sandboxed renderer (electron#21416) (electr…

757e7a9

…on#21431)

fix: prefer occluded rather than unloading layout info (electron#21751)

96cae44

Co-authored-by: loc <andy@slack-corp.com>

fix: don't fallback to OpenFolderViaShell (electron#21748)

e81aa83

Co-authored-by: Shelley Vohr <codebytere@github.com>

fix: disable private macOS APIs in MAS build except for CAContext/CAL…

ee2de31

…ayerHost (8-x-y) (electron#21574) * fix: add patch to disable remote accessibility APIs * fix: add patch to disable private window frame APIs

chore: bump chromium to 80.0.3987.51 (8-x-y) (electron#21738)

1b204a4

* chore: bump chromium in DEPS to 80.0.3987.49 * chore: bump chromium in DEPS to 80.0.3987.50 * chore: bump chromium in DEPS to 80.0.3987.51

Bump v8.0.0-beta.6

eb41994

Fix memory leak in generator functions (electron#21760)

f47fbcc

Backports https://chromium-review.googlesource.com/c/v8/v8/+/1967317

fix: stream protocols not completing (electron#21759)

5a2c451

Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>

chore: bump chromium in DEPS to 80.0.3987.55 (electron#21765)

6a88152

fix: pass full response headers in net module (electron#21769)

427c139

* fix: pass full response headers in net module * chore: put helper classes in annoymouse namespace * fix: use hasOwnProperty to test key * chore: shorter class name Co-authored-by: Cheng Zhao <zcbenz@github.com>

chore: bump chromium in DEPS to 80.0.3987.58 (electron#21789)

22e8fc6

fix: printToPDF failing to generate PDF (electron#21797)

06868c9

Co-authored-by: Shelley Vohr <codebytere@github.com>

feat: add session.addWordToSpellCheckerDictionary to allow custom wor…

048f06c

…ds in the dictionary (electron#21297) * feat: add session.addWordToSpellCheckerDictionary to allow custom words in the dictionary * Update session.md Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>

chore: bump chromium in DEPS to 80.0.3987.59 (electron#21800)

7b61e60

Bump v8.0.0-beta.7

4ce5a48

chore: bump chromium in DEPS to 80.0.3987.60 (electron#21817)

5a5b6ab

nornagon and others added 19 commits May 8, 2020 11:42

chore: cherry-pick 45b8c2bb07d2 from v8 (electron#23465)

4a45196

chore: cherry-pick 38990b7d56e6 from chromium (electron#23504)

edabc96

* chore: cherry-pick 38990b7d56e6 from chromium * update patches Co-authored-by: Electron Bot <anonymous@electronjs.org>

chore: cherry-pick 67864c214770 from Chromium (electron#23517)

2d40fad

chore: cherry-pick e89fe66d0473 from Chromium (electron#23514)

70f05a1

build: use correct v8_context_snapshot_generator in mksnapshot zip (e…

15d792a

…lectron#23542) Co-authored-by: John Kleinschmidt <jkleinsc@github.com>

fix: do not destroy thread in UI thread (electron#23550)

ea4e92f

chore: cherry-pick 86c02c5dcd37 from chromium (electron#23528)

faf2871

Co-authored-by: Andrey Belenko <anbelen@microsoft.com>

fix: run Node.js at-exit callbacks in renderer proc (electron#23564)

42ab97f

fix: leave behind the unmodified XDG_CURRENT_DESKTOP variable (electr…

f7509d5

…on#23552) Co-authored-by: Samuel Attard <sattard@slack-corp.com>

chore: cherry-pick 1288aa12369e from angle (electron#23561)

a4de479

chore: cherry-pick 7101418f85a0 from chromium (electron#23532)

dc71541

* chore: cherry-pick 7101418f85a0 from chromium * update patches Co-authored-by: Electron Bot <anonymous@electronjs.org> Co-authored-by: Andrey Belenko <anbelen@microsoft.com>

feat: add force option to app.focus() (electron#23574)

6f331e4

feat: add enableWebSQL webpreference (electron#23311) (electron#23581)

2a44b1a

build: remove unused header from a patch (electron#23591)

79298d3

It can cause build failures because the header is generated and there's no explicit dependency on a target that creates it. Co-authored-by: Aleksei Kuzmin <alkuzmin@microsoft.com>

Bump v8.3.0

426d45c

refactor: remove the RenderFrameFunctionStore and use privates to mem…

7290d77

…ory manage (electron#23592) (electron#23612)

test: fix conditions for some tests (electron#23489) (electron#23607)

6b8ca86

refactor: improve MoveItemToTrash error description (electron#23629)

a8196fb

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

net: Don't ignore the referer header in net.request

b459ad2

zeeker999 requested review from a team as code owners May 20, 2020 21:49

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 20, 2020

trop bot mentioned this pull request May 20, 2020

fix: Don't ignore the referer header in net.request #23386

Merged

4 tasks

trop bot added backport This is a backport PR master labels May 20, 2020

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 20, 2020

zeeker999 closed this May 20, 2020

zeeker999 deleted the net-referer-8-x-y branch May 20, 2020 21:50

zeeker999 restored the net-referer-8-x-y branch May 20, 2020 21:51

codebytere removed the master label Jul 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Don't ignore the referer header in net.request #23686

fix: Don't ignore the referer header in net.request #23686

zeeker999 commented May 20, 2020

fix: Don't ignore the referer header in net.request #23686

fix: Don't ignore the referer header in net.request #23686

Conversation

zeeker999 commented May 20, 2020