Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: webContents.insertCSS doesn't work when it is in Chromium-provided page #34816

Closed
3 tasks done
FlysoftBeta opened this issue Jul 3, 2022 · 2 comments
Closed
3 tasks done
Labels

Comments

@FlysoftBeta
Copy link

FlysoftBeta commented Jul 3, 2022

Preflight Checklist

Electron Version

20.0.0-beta.3

What operating system are you using?

Windows

Operating System Version

Windows 11 version 22H2

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

The promise returned by webContents.insertCSS should resolve with the key.

Actual Behavior

When the webContents loads a Chromium-provided page (eg: view-source page(like view-source:https://google.com), xml viewer, image viewer) and I try inserting CSS to the page,
the promise returned by webContents.insertCSS keeps pending and never resolves.

Testcase Gist URL

https://gist.github.com/81b8b61d974173cb9f73c67aaa03a8fd

Additional Information

Some instructions of the gist: There are two webviews on the window, and I try using insertCSS("body { background: red; }") to make the background red, but only one of them succeed.

image

and there is only one promise resolved, too.

image

@FlysoftBeta FlysoftBeta changed the title [Bug]: webContents.insertCSS doesn't work when it is in view-source page [Bug]: webContents.insertCSS doesn't work when it is in Chromium-provided page Jul 3, 2022
@ckerr
Copy link
Member

ckerr commented Sep 15, 2022

https://gist.github.com/81b8b61d974173cb9f73c67aaa03a8fd is a 404, so I'm marking this as blocked/needs-repro

@ckerr ckerr added blocked/need-repro Needs a test case to reproduce the bug 20-x-y component/webcontents labels Sep 15, 2022
@github-actions
Copy link
Contributor

Unfortunately, without a way to reproduce this issue, we're unable to continue investigation. This issue has been closed and will not be monitored further. If you're able to provide a minimal test case that reproduces this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants