[Feature Request]: Re-add support for modp1 and modp2 Diffie-Hellman groups following Node update

[Eugeny]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem Description

After nodejs/node#43896 and the related Electron patch, Electron has lost the ability to use modp1 and modp2 DH groups in node crypto (used e.g. in the ssh2 Node module to connect to Cisco hardware).

The reason for removal was that BoringSSL doesn't have these two constants while OpenSSL does and thus official node crypto module does too.

Proposed Solution

Based on my limited understanding, it should be trivial to copy-paste these group constants into the Electron patch and remove #ifdefs to bring back support for it: https://github.com/openssl/openssl/blob/master/crypto/bn/bn_const.c#L25-L74

[codebytere]

See nodejs/node#44539 (comment)

They've been deprecated in Node.js since Sept 2022 for justifiable security reasons and BoringSSL is strongly against supporting them upstream, so I apologize but this is something we're going to defer to BoringSSL and better security practices on.

[Eugeny]

BoringSSL still includes an MD5 implementation. Should we really remove support for technology that is still being used, without any available alternatives (it's the only key exchange that's available when connecting to real, physical hardware) instead of just discouraging its use in new implementations?

Especially when it's just about a numeric constant