[WIP] Upgrade to Chromium 61 #10213

alexeykuzmin · 2017-08-07T19:59:33Z

Current state

This branch depends on libcc from electron/libchromiumcontent#335.

Compilation and linking work on all platforms.
There is a couple of failing and temporary disabled tests.

TODOs

For review

Done

a3438e7 FIXME: DesktopNotificationDelegate has been removed
9a08f42 REVIEW: Reporting: Wire ReportingDelegate into ChromeNetworkDelegate
24dbc39 FIXME: Refactor client cert private key handling. [deepak1556]
44d1fd2 FIXME: Use sk_tool_utils::copy_to() instead of .deepCopyTo().
9b29aa8 REVIEW: Move handling of DraggableRegionsChanged notification from "view" to "frame".
49d2d98 REVIEW: Remove obsolete Blink popup blocker.
1bed73a FIXME: Remove "async" option from menu.popup()
54a6d14 REVIEW: Fix 'constructor cannot be redeclared' error
4f20949 REVIEW: Move MediaDeviceIDSalt from ProfileIOData to ProfileImpl.
ae62ad4 FIXME: Remove corsEnabled option from webFrame.registerURLSchemeAsPrivileged()

Tests

Disabled

<webview> tag > found-in-page event > emits when a request is made Fix it in Fix "<webview> tag found-in-page event emits when a request is made" test #11244
nativeImage module > addRepresentation() > * (3 tests) 2357b7c fix doesn't seem to work, it makes "nativeImage module > toDataURL() returns a PNG data URL" fail; /cc @alespergl Fix it in Fix "nativeImage module addRepresentation() ..." tests #11245
crashReporter module > {with,without} sandbox > should send minidump when renderer crashes Fix all crashReporter tests in Fix "crashReporter module" tests #11246
crashReporter module > {with,without} sandbox > should send minidump when node processes crash
crashReporter module > {with,without} sandbox > should send minidump with updated extra parameters
crashReporter module > {with,without} sandbox > should not send minidump if uploadToServer is false

Failing

vulture · 2017-08-10T20:29:08Z

I know this is still a WIP, so nbd if you'd rather I just wait, but I was hoping to get a jump on the latest version for testing etc. I noticed a couple issues with this branch currently:

with libcc it seems the submodule commit from electron/electron is set to electron/libchromiumcontent@f80bc17, but this is no longer part of the upgrade-to-chromium-61 branch (or any branch) in the libcc repo @ https://github.com/electron/libchromiumcontent/commits/upgrade-to-chromium-61 . This causes an error in script/bootstrap during submodule init, and bootstrap will refuse to continue (e.g., fatal: reference is not a tree: f80bc17303ff531635c1d6431abf08f00698b086). Going to vendor/libchromiumcontent, checking out upgrade-to-chromium-61, and committing locally, allows bootstrap to succeed in that respect.
however after doing the above, downloading libchromiumcontent.zip from https://s3.amazonaws.com/github-janky-artifacts/libchromiumcontent/win/ia32/ec19c63535e411c2be70a6c6bc0ab8853989362c/libchromiumcontent.zip fails, because that hash is different from what was committed in electron/electron. Using the electron-committed-broken-hash https://s3.amazonaws.com/github-janky-artifacts/libchromiumcontent/win/ia32/f80bc17303ff531635c1d6431abf08f00698b086/libchromiumcontent.zip will succeed.

alexeykuzmin · 2017-08-10T21:10:14Z

@vulture Yes, it is WIP and it's going to stay WIP for some time, probably weeks.
Right now it's in a quite messed up state, it's basically just a set of compilation fixes and it cannot be built.

I personally don't recommend to try to use it (even for testing) until the Chromium 61 is released, which is scheduled on September 5th.

alexeykuzmin · 2017-08-11T09:20:31Z

atom/renderer/atom_render_view_observer.cc

+  // script to run while `window.location` is still "about:blank".
+  blink::WebDocument document = frame->GetDocument();
+  blink::WebElement html_element = document.DocumentElement();
+  if (html_element.IsNull()) {


@zcbenz It's Ch61 upgrade related so not very urgent.

Is this check equivalent to to that you did in 0bcc9b7?
DidCreateDocumentElement() method was removed from content::RenderViewObserver
(it is still present in content::RenderFrameObserver).

Yeah it should be the same, Chromium is in the process of deprecating RenderViewObserver for RenderFrameObserver, so eventually we should migrate code of atom_render_view_observer.cc to use atom_render_frame_observer.cc.

Cool, thanks.

alexeykuzmin · 2017-08-23T23:12:30Z

atom/browser/ui/webui/pdf_viewer_ui.cc

@@ -144,7 +144,7 @@ class PdfViewerUI::ResourceRequester

    std::unique_ptr<content::ResourceHandler> handler =
        base::MakeUnique<content::StreamResourceHandler>(
-            request.get(), stream_context->registry(), origin);
+            request.get(), stream_context->registry(), origin, false);


Needs a review.

CapOM · 2017-09-14T13:59:28Z

Hi is there a way to try electron with chromium 61 using npm install electron@1.X.0 ?

I would like to try ES6 support, so far it fails for:

=> "Uncaught SyntaxError: Unexpected token import"

I am using electron 1.8.0 with "webPreferences: {blinkFeatures: ModuleScripts"} passed to new BrowserWindow.

MarshallOfSound · 2017-09-14T14:03:30Z

Hi is there a way to try electron with chromium 61 using npm install electron@1.X.0 ?

Not currently, the upgrade is still a WIP

alexeykuzmin · 2017-09-22T04:05:09Z

@MarshallOfSound
Oh, hi Sam! So many thanks for helping us with the upgrade )

MarshallOfSound · 2017-09-22T04:20:51Z

@alexeykuzmin Haha, fixed a few issues on Windows still a weird "cannot use __try on objects that require unwinding" error that I looked into but couldn't figure out the change that broke the code 🤔

vulture · 2017-09-22T06:05:41Z

@MarshallOfSound simplified version: you cant mix __try and C++ implicit object destructors basically... , like e.g. using a std::string inside a __try will trigger that error.

a simple fix is to put C++ object usage inside a separate function, then __try { callfunction(); } __except(....)

…and run on Mac

* _debugWaitConnect => _breakFirstLine * Use default thread pool size specified by node.cc

…s made" test

zcbenz · 2017-11-24T01:59:28Z

I'm rebasing this PR to fix the conflicts introduced by the mips changes. The build state is not supposed to change.

zcbenz · 2017-11-24T02:12:42Z

I'm turning on the just-added 2xlarge resource class for the arm CI jobs, which should be able to fix the failing arm release build.

alexeykuzmin · 2017-11-24T09:59:19Z

I'll create tasks to fix and enable disabled tests right after this PR is merged.

Here they are: #11242, #11243, #11244, #11245, #11246

SatoshiKawabata · 2017-12-01T09:39:50Z

@alexeykuzmin When will this be included to beta?

alexeykuzmin · 2017-12-01T09:41:55Z

@SatoshiKawabata when the team is ready to release a beta. No dates, sorry.

SatoshiKawabata · 2017-12-01T09:44:08Z

@alexeykuzmin OK. I'm looking forward to this. Thanks.

SatoshiKawabata · 2017-12-05T05:15:13Z

@alexeykuzmin Does v1.8.2-beta.3 include this PR?

HitomiTenshi · 2017-12-05T10:27:17Z

@SatoshiKawabata no, you can see it's still Chrome 59 when you open the dev tools.

You'll also have to wait for #10836 to get sorted out. Patience my man.
The new Electron version with Chrome 61 will probably get released as 1.9.x because of the Chrome and Node JS upgrades.

alexeykuzmin · 2017-12-05T11:29:34Z

@SatoshiKawabata No, it doesn't. Versions 1.8.x are based on Chromium 59.

SatoshiKawabata · 2017-12-05T23:52:38Z

I see. Patience! Thanks.

karelbilek · 2017-12-12T23:59:42Z

Hello. Just for information. Does Electron 1.9.X with Chrome 61 support webusb?

This was referenced Aug 7, 2017

[WIP] Upgrade to Chromium 60 #10194

Closed

Upgrade to Chromium 61 #10211

Closed

jkleinsc force-pushed the upgrade-to-chromium-59 branch from 0c4e6c6 to 44bc4b9 Compare August 9, 2017 21:43

alexeykuzmin commented Aug 11, 2017

View reviewed changes

alexeykuzmin force-pushed the upgrade-to-chromium-61 branch from 26848a0 to a3f2e8d Compare August 11, 2017 11:21

alexeykuzmin force-pushed the upgrade-to-chromium-59 branch 11 times, most recently from baa3c0d to 5543bfc Compare August 16, 2017 11:29

tonyganch changed the base branch from upgrade-to-chromium-59 to master August 16, 2017 14:33

tonyganch force-pushed the upgrade-to-chromium-61 branch from 1326ab4 to 7ec2fdc Compare August 17, 2017 13:45

alexeykuzmin force-pushed the upgrade-to-chromium-61 branch from 7ec61a9 to d8ea91d Compare August 23, 2017 22:44

alexeykuzmin commented Aug 23, 2017

View reviewed changes

alexeykuzmin force-pushed the upgrade-to-chromium-61 branch from 6e1a3b9 to 3dcc27d Compare August 24, 2017 12:09

alexeykuzmin force-pushed the upgrade-to-chromium-61 branch from 5867e53 to 039b6ab Compare August 31, 2017 16:55

alexeykuzmin force-pushed the upgrade-to-chromium-61 branch from f35e78b to 74a8cf1 Compare September 14, 2017 09:15

alexeykuzmin and others added 12 commits November 24, 2017 10:58

Use Node.js v8.7.0

ad732b4

Use node::NodePlatform instead of v8::platform in atom::NodeDebugger

1cf95d2

Adding node headers to native modules for tests so they will compile …

207150c

…and run on Mac

Fix "nghttp2" build

11f7bb3

Fix node_debugger api changes

ed4482d

* _debugWaitConnect => _breakFirstLine * Use default thread pool size specified by node.cc

add basic inspector module test

0b88873

Disable "nativeImage module > addRepresentation()" tests

c73ba58

Disable "<webview> tag > found-in-page event > emits when a request i…

d61564b

…s made" test

Disable a couple of crashReporter tests

efd949e

Fix linking problem with NodePlatform

3138c85

Fix uninitialized NodePlatform

a34d45d

Use latest libcc

8e70869

zcbenz force-pushed the upgrade-to-chromium-61 branch from ae26f2c to 8e70869 Compare November 24, 2017 01:59

Use 2xlarge for ARM jobs

c30faa4

zcbenz approved these changes Nov 24, 2017

View reviewed changes

codebytere merged commit c18afc9 into master Nov 24, 2017

codebytere deleted the upgrade-to-chromium-61 branch November 24, 2017 09:17

50Wliu mentioned this pull request Dec 6, 2017

Improve performance of placing placeholder atom/tabs#390

Merged

mjkramer mentioned this pull request Feb 8, 2018

Allow to change the background color of menu bar (Windows & some Linux) microsoft/vscode#16363

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Upgrade to Chromium 61 #10213

[WIP] Upgrade to Chromium 61 #10213

alexeykuzmin commented Aug 7, 2017 •

edited

Loading

vulture commented Aug 10, 2017

alexeykuzmin commented Aug 10, 2017 •

edited

Loading

alexeykuzmin Aug 11, 2017

zcbenz Aug 14, 2017

alexeykuzmin Aug 14, 2017

alexeykuzmin Aug 23, 2017

CapOM commented Sep 14, 2017

MarshallOfSound commented Sep 14, 2017

alexeykuzmin commented Sep 22, 2017

MarshallOfSound commented Sep 22, 2017

vulture commented Sep 22, 2017 •

edited

Loading

zcbenz commented Nov 24, 2017

zcbenz commented Nov 24, 2017

alexeykuzmin commented Nov 24, 2017

SatoshiKawabata commented Dec 1, 2017

alexeykuzmin commented Dec 1, 2017

SatoshiKawabata commented Dec 1, 2017

SatoshiKawabata commented Dec 5, 2017

HitomiTenshi commented Dec 5, 2017 •

edited

Loading

alexeykuzmin commented Dec 5, 2017

SatoshiKawabata commented Dec 5, 2017

karelbilek commented Dec 12, 2017

[WIP] Upgrade to Chromium 61 #10213

[WIP] Upgrade to Chromium 61 #10213

Conversation

alexeykuzmin commented Aug 7, 2017 • edited Loading

Current state

TODOs

For review

Done

Tests

Disabled

Failing

vulture commented Aug 10, 2017

alexeykuzmin commented Aug 10, 2017 • edited Loading

alexeykuzmin Aug 11, 2017

Choose a reason for hiding this comment

zcbenz Aug 14, 2017

Choose a reason for hiding this comment

alexeykuzmin Aug 14, 2017

Choose a reason for hiding this comment

alexeykuzmin Aug 23, 2017

Choose a reason for hiding this comment

CapOM commented Sep 14, 2017

MarshallOfSound commented Sep 14, 2017

alexeykuzmin commented Sep 22, 2017

MarshallOfSound commented Sep 22, 2017

vulture commented Sep 22, 2017 • edited Loading

zcbenz commented Nov 24, 2017

zcbenz commented Nov 24, 2017

alexeykuzmin commented Nov 24, 2017

SatoshiKawabata commented Dec 1, 2017

alexeykuzmin commented Dec 1, 2017

SatoshiKawabata commented Dec 1, 2017

SatoshiKawabata commented Dec 5, 2017

HitomiTenshi commented Dec 5, 2017 • edited Loading

alexeykuzmin commented Dec 5, 2017

SatoshiKawabata commented Dec 5, 2017

karelbilek commented Dec 12, 2017

alexeykuzmin commented Aug 7, 2017 •

edited

Loading

alexeykuzmin commented Aug 10, 2017 •

edited

Loading

vulture commented Sep 22, 2017 •

edited

Loading

HitomiTenshi commented Dec 5, 2017 •

edited

Loading