Technical debt after the Chromium 61 upgrade

[alexeykuzmin]

List of hacks and workarounds made during the upgrade to Chromium 61.
We should probably fix them before Chromium 61 is merged or right after.

/cc @zcbenz, @tonyganch, @gavignus, @alespergl, @deepak1556, @MarshallOfSound

Probably should be fixed before the release

• [electron] Fix "<webview> tag found-in-page event emits when a request is made" test #11244 Fix "<webview> tag found-in-page event emits when a request is made" test
• [electron] Fix "nativeImage module addRepresentation() ..." tests #11245 Fix "nativeImage module addRepresentation() ..." tests
• [electron] Fix "crashReporter module" tests #11246 Fix "crashReporter module" tests
• [electron] Assertion failed: (err == 0), function uv_loop_delete, file ../../vendor/node/deps/uv/src/uv-common.c, line 661. #11243 Assertion failed: (err == 0), function uv_loop_delete, file ../../vendor/node/deps/uv/src/uv-common.c, line 661.
• [docs] Remove async menu from the docs #11242 Remove async menu from the docs

---

Probably can be safely postponed

• [libcc] New patch: Checking pointer returned from browser plug-in. Ignoring nullptr values which would cause BAD ACCESS errors libchromiumcontent#399 New patch: Checking pointer returned from browser plug-in. Ignoring nullptr values which would cause BAD ACCESS errors
• [electron] Fix "onbeforeunload" tests #10754 Fix "onbeforeunload" tests
• [electron] Deprecate and remove "corsEnabled" option from "webFrame.registerURLSchemeAsPrivileged" #10776 Deprecate and remove "corsEnabled" option from "webFrame.registerURLSchemeAsPrivileged"
• [electron] Fix GTK deprecation warnings #10780 Fix GTK deprecation warnings
• [electron] FIXME: Use sk_tool_utils::copy_to() instead of .deepCopyTo(). #11248 FIXME: Use sk_tool_utils::copy_to() instead of .deepCopyTo().
• [libcc] Use custom libc++? libchromiumcontent#400 Use custom libc++?
• [node] FIXME: Use redefined version of the internalModuleStat function node#26 FIXME: Use redefined version of the internalModuleStat function
• [node] UPSTREAM: Include node_platform.h instead of forward declaration node#25 UPSTREAM: Include node_platform.h instead of forward declaration
• [electron] Fix an alpha type of a bitmap returned by gfx::JPEGCodec::Decode() #11294 Fix an alpha type of a bitmap returned by gfx::JPEGCodec::Decode()

[ibash]

#11243 is merged - release the beta! :)

[CapOM]

An update on this ?

[nornagon]

@CapOM are you looking for any specific info? most of the items listed have been completed.

[CapOM]

I get some crashes with nativeImage.createFromPath when it has Template in its name after upgrading electron (see https://electronjs.org/docs/api/native-image#template-image) so I was wondering if something was still pending.

[nornagon]

Please open a new bug for the issue you're seeing, I think this one has cobwebs on it :)

[CapOM]

Opened here #16408