Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix links to Documentation Translations #11091

Closed
wants to merge 1 commit into from
Closed

fix links to Documentation Translations #11091

wants to merge 1 commit into from

Conversation

marswong
Copy link

No description provided.

@marswong marswong requested a review from a team November 11, 2017 02:07
@welcome
Copy link

welcome bot commented Nov 11, 2017

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.
    We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@zeke
Copy link
Contributor

zeke commented Nov 11, 2017

Thanks @marswong. However as of #11039, this repo is no longer the home of translated docs.

This entire section and list should probably just be removed and replaced with a link to https://github.com/electron/electron-i18n#readme where a more up-to-date list of languages is available. We could could also link to the new /docs-translations/README.md which explains how to access the raw markdown docs for each language.

@marswong
Copy link
Author

@zeke got it.

@marswong marswong closed this Nov 11, 2017
@zeke zeke self-assigned this Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants