New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dialog does not close on ESCAPE if defaultId is set (Mac) (backport: 3-0-x) #14205

Merged
merged 1 commit into from Aug 19, 2018

Conversation

Projects
None yet
3 participants
@trop

trop bot commented Aug 19, 2018

Backport of #14196

See that PR for details.

Notes: no-notes

@trop trop bot requested a review from electron/reviewers as a code owner Aug 19, 2018

@trop trop bot referenced this pull request Aug 19, 2018

Merged

fix: Dialog does not close on ESCAPE if defaultId is set (Mac) #14196

2 of 2 tasks complete

@trop trop bot added the backport label Aug 19, 2018

@MarshallOfSound MarshallOfSound merged commit 0783eb9 into electron:3-0-x Aug 19, 2018

11 of 13 checks passed

ci/circleci: electron-mas-x64 CircleCI is running your tests
Details
ci/circleci: electron-osx-x64 CircleCI is running your tests
Details
Semantic Pull Request ready to be squashed
Details
WIP ready for review
Details
appveyor: electron-ia32-pr AppVeyor build succeeded
Details
appveyor: electron-x64-pr AppVeyor build succeeded
Details
ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64-test Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Show comment
Hide comment
@release-clerk

release-clerk bot Aug 19, 2018

No Release Notes

release-clerk bot commented Aug 19, 2018

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment